From fec931d899a039a58fb691e0c10d9bc602be81e2 Mon Sep 17 00:00:00 2001 From: Alex Creasy Date: Mon, 17 Jul 2023 17:21:04 +0100 Subject: [PATCH] Revert "Merge pull request #1503 from alexcreasy/configurable-thanos-port" This reverts commit cfbe4f284f174fa36203407c34c44f164a028d0c, reversing changes made to 0683de3c2215484f4c45193305b389cbf6d28165. --- backend/src/routes/api/prometheus/index.ts | 2 -- backend/src/utils/constants.ts | 3 --- backend/src/utils/prometheusUtils.ts | 5 ++--- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/backend/src/routes/api/prometheus/index.ts b/backend/src/routes/api/prometheus/index.ts index c62dbb55e0..6e0b3ccc9e 100644 --- a/backend/src/routes/api/prometheus/index.ts +++ b/backend/src/routes/api/prometheus/index.ts @@ -9,7 +9,6 @@ import { import { callPrometheusThanos } from '../../../utils/prometheusUtils'; import { createCustomError } from '../../../utils/requestUtils'; import { logRequestDetails } from '../../../utils/fileUtils'; -import { THANOS_DEFAULT_OAUTH_PORT } from '../../../utils/constants'; const handleError = (e: createError.HttpError) => { if (e?.code) { @@ -57,7 +56,6 @@ module.exports = async (fastify: KubeFastifyInstance) => { request, query, QueryType.QUERY_RANGE, - THANOS_DEFAULT_OAUTH_PORT, ).catch(handleError); }, ); diff --git a/backend/src/utils/constants.ts b/backend/src/utils/constants.ts index 2a3bb8fc98..455dc14084 100644 --- a/backend/src/utils/constants.ts +++ b/backend/src/utils/constants.ts @@ -135,6 +135,3 @@ export const DEFAULT_NOTEBOOK_SIZES: NotebookSize[] = [ export const imageUrlRegex = /^([\w.\-_]+((?::\d+|)(?=\/[a-z0-9._-]+\/[a-z0-9._-]+))|)(?:\/|)([a-z0-9.\-_]+(?:\/[a-z0-9.\-_]+|))(?::([\w.\-_]{1,127})|)/; - -export const THANOS_DEFAULT_RBAC_PORT = '9092'; -export const THANOS_DEFAULT_OAUTH_PORT = '9091'; diff --git a/backend/src/utils/prometheusUtils.ts b/backend/src/utils/prometheusUtils.ts index f1f299b119..a51bbb1173 100644 --- a/backend/src/utils/prometheusUtils.ts +++ b/backend/src/utils/prometheusUtils.ts @@ -4,7 +4,7 @@ import { PrometheusQueryRangeResponse, QueryType, } from '../types'; -import { DEV_MODE, THANOS_DEFAULT_RBAC_PORT } from './constants'; +import { DEV_MODE } from './constants'; import { getNamespaces } from './notebookUtils'; import { getDashboardConfig } from './resourceUtils'; import { createCustomError } from './requestUtils'; @@ -88,13 +88,12 @@ export const callPrometheusThanos = ( request: OauthFastifyRequest, query: string, queryType: QueryType = QueryType.QUERY, - port = THANOS_DEFAULT_RBAC_PORT, ): Promise<{ code: number; response: T }> => callPrometheus( fastify, request, query, - generatePrometheusHostURL(fastify, 'thanos-querier', 'openshift-monitoring', port), + generatePrometheusHostURL(fastify, 'thanos-querier', 'openshift-monitoring', '9092'), queryType, );