-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate meaningful name for custom notebook image #1435
Comments
@DaoDaoNoCode additionally, if not done so yet, a meaningful name should also be set for imagestream metadata.annotations |
@shalberd We tend to use this annotation for internal resources in the dashboard, both of them are to add descriptions and display names to render in the dashboard. I wasn't aware of that annotation in the notebook, so it's up to @DaoDaoNoCode to see which one fits best for our logic |
@shalberd Hmm, interesting, I didn't know we have this annotation before. I guess if we want to also show the OOTB images in the future, we should adopt the same annotations. So I agree that we should use |
@harshad16 do you have documentation behind these annotations? |
We haven't clearly documented the annotation in the imagestream. |
Goal
Allow users to set a display name for the custom images they are importing and generate a meaningful k8s name
Dependency issue
Tracker: #1254
Itemized goals
When adding custom images, the image stream names are not intuitive - eg. 'byon-xxxx'. This makes it hard to differentiate across custom images. Would like the name to be more intuitive and not include 'byon' prefix.
Aspects continued elsewhere
No response
Mocks
No mocks
The text was updated successfully, but these errors were encountered: