Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-expand deployed models column when a model is deployed #1605

Closed
lucferbux opened this issue Jul 28, 2023 · 3 comments
Closed

Auto-expand deployed models column when a model is deployed #1605

lucferbux opened this issue Jul 28, 2023 · 3 comments
Assignees
@DaoDaoNoCode
Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.

Comments

@lucferbux
Copy link
Contributor

Goal

Auto expand deployed models column in model serving table when a new model is deployed for an specific model server

Dependency issue

No dependencies

Itemized goals

  • Focus the deployed models tab when a model is deployed
  • Focus only the tab for the given model server row

Aspects continued elsewhere

No response

Mocks
@lucferbux lucferbux added priority/high Important issue that needs to be resolved asap. Releases should not have too many of these. feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. labels Jul 28, 2023
@lucferbux lucferbux mentioned this issue Jul 26, 2023
Closed
@DaoDaoNoCode
Copy link
Member

I think this issue will be solved at #1646

@dpanshug
Copy link
Contributor

dpanshug commented Sep 18, 2023 •
edited
Loading

I think this issue will be solved at #1646

#1646 Solved the first goal of this issue: "Focus the deployed models tab when a model is deployed"
But it still needs to solve: "Focus only the tab for the given model server row"

Edit: My bad, this issue is fully resolved in the latest main branch.

@lucferbux Can we close this issue?

@dpanshug dpanshug assigned dpanshug and unassigned dpanshug Sep 18, 2023
@DaoDaoNoCode DaoDaoNoCode self-assigned this Sep 18, 2023
@DaoDaoNoCode
Copy link
Member

Follow-up fix in #1777, this PR is merged and the issue is fully fixed. Closing it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaoDaoNoCode DaoDaoNoCode

Labels
feature/model-serving Model Serving Feature kind/story A user story for larger work. Should always be referenced by a "tracker" labelled issue. priority/high Important issue that needs to be resolved asap. Releases should not have too many of these.
Projects
ODH Feature Tracking
Status: No status
ODH Dashboard Planning
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lucferbux @DaoDaoNoCode @dpanshug