Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update coverage on push and pull_request #2806

Merged
merged 1 commit into from
May 10, 2024
Merged

update coverage on push and pull_request #2806

merged 1 commit into from
May 10, 2024

Conversation

christianvogt
Copy link
Contributor

@christianvogt christianvogt commented May 10, 2024 •
edited
Loading

Description

Code coverage results need to be uploaded for main. A github workflow is required to upload the coverage results for main when code is pushed to the main branch. The current workflow is only running for pull_requests. As such there is no "base report" uploaded to codecov for PRs to create a comparison to.

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label May 10, 2024
@openshift-ci openshift-ci bot requested review from pnaik1 and ppadti May 10, 2024 18:16
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@f3927fd). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2806   +/-   ##
=======================================
  Coverage        ?   77.23%           
=======================================
  Files           ?     1072           
  Lines           ?    22417           
  Branches        ?     5666           
=======================================
  Hits            ?    17314           
  Misses          ?     5103           
  Partials        ?        0

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3927fd...dd082bf. Read the comment docs.

@christianvogt christianvogt changed the title [WIP] codecov testing [WIP] update coverage on push and pull_request May 10, 2024
@christianvogt christianvogt changed the title [WIP] update coverage on push and pull_request update coverage on push and pull_request May 10, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label May 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3135933 into opendatahub-io:main May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnaik1 pnaik1 Awaiting requested review from pnaik1

@ppadti ppadti Awaiting requested review from ppadti

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianvogt @codecov-commenter