Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHOAIENG-7485] Admin - Database status in Model Registry Table #3046

Merged
merged 1 commit into from
Jul 31, 2024
Merged

[RHOAIENG-7485] Admin - Database status in Model Registry Table #3046

merged 1 commit into from
Jul 31, 2024

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jul 30, 2024 •
edited
Loading

https://issues.redhat.com/browse/RHOAIENG-7485

Description

Show various statuses depending on model registry conditions within a new column labeled "Status" for the model registry list table page.

image

Degrading popover
image

Unavailable with multiple messages
image
(cc @yih-wang)

How Has This Been Tested?

Manually tested with sample data, created unit tests with possible status scenarios

Test Impact

Added unit tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@yih-wang
Copy link

We should use the Alert popover to display messages. Use variant Danger for Unavailable and variant Warning (or possibly Custom if the warning icon is hard-coded) for Degrading.

@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Jul 31, 2024

We should use the Alert popover to display messages. Use variant Danger for Unavailable and variant Warning (or possibly Custom if the warning icon is hard-coded) for Degrading.

@yih-wang Updated. I've also updated the screenshots in the description.

@jpuzz0 jpuzz0 requested a review from mturley July 31, 2024 14:35
mturley
mturley requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit, everything else LGTM

frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx Show resolved Hide resolved
@jpuzz0 jpuzz0 requested a review from mturley July 31, 2024 19:05
mturley
mturley approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the help!

@openshift-ci openshift-ci bot added the lgtm label Jul 31, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3c946bf into opendatahub-io:main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@mturley mturley

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpuzz0 @yih-wang @mturley