Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to Registered models #3076

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Update links to Registered models #3076

merged 1 commit into from
Aug 13, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Aug 8, 2024 •
edited
Loading

Closes: RHOAIENG-10503

Description

This PR aims to update the links to Registered Models to use the right registry name.

How Has This Been Tested?

  • Create a model registry that starts with an earlier alphabetical letter than modelregistry-sample so it will show up above that in the selector. (currently on the modelregistry-ui cluster the "dallas-mr" registry is in this position.
  • Navigate to the Model Registry page / registered models table and select the modelregistry-sample registry.
  • Reload the page.
  • Click on a registered model and observe that the right registry is in the URL.

Test Impact

Updated cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti ppadti requested a review from mturley August 8, 2024 09:16
@mturley
Copy link
Contributor

mturley commented Aug 8, 2024 •
edited
Loading

/hold

We're about to merge #3034 and this will conflict with it. I still need to review it, I'll point out the conflict resolutions we need

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Aug 8, 2024
mturley
mturley requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to address in your changes here. Also, now that #3034 is merged there are some conflicts here. Can you rebase and resolve them? Let me know if you want help with that resolution.

frontend/src/__tests__/cypress/cypress/tests/mocked/modelRegistry/modelVersions.cy.ts Outdated Show resolved Hide resolved
frontend/src/pages/modelRegistry/ModelRegistryCoreLoader.tsx Outdated Show resolved Hide resolved
@mturley
Copy link
Contributor

mturley commented Aug 8, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold This PR is hold for some reason label Aug 8, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Aug 8, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Aug 9, 2024
mturley
mturley requested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing, otherwise LGTM

frontend/src/pages/modelRegistry/ModelRegistryCoreLoader.tsx Outdated Show resolved Hide resolved
manaswinidas
manaswinidas approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Works fine. Followed steps in the JIRA and now the link points to the correct MR after selecting a registered model in a specific MR.

@openshift-ci openshift-ci bot added the lgtm label Aug 13, 2024
mturley
mturley approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Working great, thanks @ppadti !

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit eed1f1f into opendatahub-io:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

@manaswinidas manaswinidas manaswinidas approved these changes

@christianvogt christianvogt Awaiting requested review from christianvogt

@DaoDaoNoCode DaoDaoNoCode Awaiting requested review from DaoDaoNoCode

Assignees

@mturley mturley

@manaswinidas manaswinidas

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ppadti @mturley @manaswinidas @openshift-merge-robot