diff --git a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts index de5fe41bac..91c57b4e1b 100644 --- a/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts +++ b/frontend/src/__tests__/cypress/cypress/pages/pipelines/topology.ts @@ -98,7 +98,7 @@ class ArtifactRightDrawer extends Contextual { } findVisualizationTab() { - return this.find().findByRole('tab', { name: 'Visualization' }); + return this.find().findByRole('tab', { name: 'Artifact preview' }); } findIframeContent() { diff --git a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts index e29fe975e1..7a2ee9ece4 100644 --- a/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts +++ b/frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/artifacts.cy.ts @@ -206,7 +206,7 @@ describe('Artifacts', () => { ); }); }); - describe('Pipeline run visualization tab', () => { + describe('Pipeline run Artifact preview tab', () => { beforeEach(() => { cy.interceptOdh( 'GET /api/service/pipelines/:namespace/:serviceName/apis/v2beta1/artifacts/:artifactId', @@ -224,7 +224,7 @@ describe('Artifacts', () => { initMlmdIntercepts(projectName); }); - it('check for visualization', () => { + it('check for Artifact preview', () => { pipelineRunDetails.visit( projectName, mockPipeline.pipeline_id, diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx index 26ea2e973b..facc86935f 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/__tests__/PipelineRunDrawerRightContent.spec.tsx @@ -84,7 +84,7 @@ describe('PipelineRunDrawerRightContent', () => { expect(tabs).toHaveLength(2); expect(screen.getByRole('tab', { name: 'Artifact details' })).toBeVisible(); - expect(screen.getByRole('tab', { name: 'Visualization' })).toBeVisible(); + expect(screen.getByRole('tab', { name: 'Artifact preview' })).toBeVisible(); }); it('renders task drawer tabs when the task prop is of type "groupTask"', async () => { diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx index a3a3b437dd..e93bb10681 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/ArtifactNodeDrawerContent.tsx @@ -27,7 +27,7 @@ type ArtifactNodeDrawerContentProps = Omit< enum ArtifactNodeDrawerTab { Details = 'details', - Visualization = 'visualization', + ArtifactPreview = 'artifactPreview', } export const ArtifactNodeDrawerContent: React.FC = ({ @@ -66,9 +66,9 @@ export const ArtifactNodeDrawerContent: React.FC {isMetricsArtifactType(artifact.getType()) && ( Visualization} - aria-label="Visualization" + eventKey={ArtifactNodeDrawerTab.ArtifactPreview} + title={Artifact preview} + aria-label="Artifact preview" > diff --git a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx index f2f938edb2..721ced8f45 100644 --- a/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx +++ b/frontend/src/concepts/pipelines/content/pipelinesDetails/pipelineRun/artifacts/__tests__/ArtifactNodeDrawerContent.spec.tsx @@ -115,7 +115,7 @@ describe('ArtifactNodeDrawerContent', () => { ), ); - await user.click(screen.getByRole('tab', { name: 'Visualization' })); + await user.click(screen.getByRole('tab', { name: 'Artifact preview' })); expect(screen.getByRole('heading', { name: 'Scalar metrics' })).toBeVisible(); }); @@ -154,7 +154,7 @@ describe('ArtifactNodeDrawerContent', () => { ), ); - await user.click(screen.getByRole('tab', { name: 'Visualization' })); + await user.click(screen.getByRole('tab', { name: 'Artifact preview' })); expect(screen.getByRole('heading', { name: 'ROC curve' })).toBeVisible(); }); @@ -179,7 +179,7 @@ describe('ArtifactNodeDrawerContent', () => { , ); - await user.click(screen.getByRole('tab', { name: 'Visualization' })); + await user.click(screen.getByRole('tab', { name: 'Artifact preview' })); expect(screen.getByRole('heading', { name: 'Confusion matrix metrics' })).toBeVisible(); }); @@ -202,7 +202,7 @@ describe('ArtifactNodeDrawerContent', () => { , ); - expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull(); + expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull(); }); it('should not render "Model" visualization drawer tab', async () => { @@ -224,7 +224,7 @@ describe('ArtifactNodeDrawerContent', () => { , ); - expect(screen.queryByRole('tab', { name: 'Visualization' })).toBeNull(); + expect(screen.queryByRole('tab', { name: 'Artifact preview' })).toBeNull(); }); });