Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support editing connection with unmatched connection type #3326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

support editing connection with unmatched connection type

12ebf0a
Select commit
Loading
Failed to load commit list.
Open

support editing connection with unmatched connection type #3326

support editing connection with unmatched connection type
12ebf0a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 0s

84.83% (-0.02%) compared to f6ec5a6

View this Pull Request on Codecov

84.83% (-0.02%) compared to f6ec5a6

Details

Codecov Report

Attention: Patch coverage is 92.42424% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.83%. Comparing base (f6ec5a6) to head (12ebf0a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 92.68% 3 Missing ⚠️
...cts/screens/detail/connections/ConnectionsList.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3326      +/-   ##
==========================================
- Coverage   84.85%   84.83%   -0.02%     
==========================================
  Files        1321     1321              
  Lines       29446    29471      +25     
  Branches     8037     8049      +12     
==========================================
+ Hits        24986    25002      +16     
- Misses       4460     4469       +9     
Files with missing lines Coverage Δ
...ncepts/connectionTypes/fields/BooleanFormField.tsx 62.50% <ø> (-5.93%) ⬇️
frontend/src/concepts/connectionTypes/utils.ts 92.92% <100.00%> (+0.19%) ⬆️
...eens/detail/connections/ManageConnectionsModal.tsx 93.54% <100.00%> (+0.07%) ⬆️
...cts/screens/detail/connections/ConnectionsList.tsx 92.30% <50.00%> (-7.70%) ⬇️
...rc/concepts/connectionTypes/ConnectionTypeForm.tsx 88.73% <92.68%> (+0.49%) ⬆️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ec5a6...12ebf0a. Read the comment docs.