From b824f30a0ca72af8c91e9d72b46feee1720b04d8 Mon Sep 17 00:00:00 2001 From: Yulia Krimerman Date: Mon, 14 Oct 2024 15:50:15 -0400 Subject: [PATCH 1/4] make howerable --- .../ModelRegistryTableRowStatus.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index 734cef714c..f9752c8760 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -119,7 +119,14 @@ export const ModelRegistryTableRowStatus: React.FC + ); From 8d7a723cdd8ff5ab456f0a74ed2de9954631ba6b Mon Sep 17 00:00:00 2001 From: Yulia Krimerman Date: Mon, 14 Oct 2024 15:54:32 -0400 Subject: [PATCH 2/4] make howerable1 --- .../pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index f9752c8760..46363c5ae3 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -125,7 +125,6 @@ export const ModelRegistryTableRowStatus: React.FC {statusLabel} From 702231d024f7d2dd47addfe3921ae3cc6d1f7fee Mon Sep 17 00:00:00 2001 From: Yulia Krimerman Date: Tue, 15 Oct 2024 11:11:34 -0400 Subject: [PATCH 3/4] addressed comments --- .../modelRegistrySettings/ModelRegistryTableRowStatus.tsx | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index 46363c5ae3..2ae7bf7e66 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -30,7 +30,6 @@ enum ConditionStatus { True = 'True', False = 'False', } - interface ModelRegistryTableRowStatusProps { conditions: K8sCondition[] | undefined; } @@ -118,9 +117,13 @@ export const ModelRegistryTableRowStatus: React.FC void 0} + {...(isClickable ? { onClick: () => {} } : {})} data-testid="model-registry-label" icon={icon} color={color} From 10bc6e3703c57f08ae57cf831d74310690660005 Mon Sep 17 00:00:00 2001 From: Yulia Krimerman Date: Tue, 15 Oct 2024 11:24:34 -0400 Subject: [PATCH 4/4] fix failure --- .../modelRegistrySettings/ModelRegistryTableRowStatus.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx index 2ae7bf7e66..65b6717d31 100644 --- a/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx +++ b/frontend/src/pages/modelRegistrySettings/ModelRegistryTableRowStatus.tsx @@ -123,7 +123,13 @@ export const ModelRegistryTableRowStatus: React.FC {} } : {})} + {...(isClickable + ? { + onClick: () => { + /* intentional no-op */ + }, + } + : {})} data-testid="model-registry-label" icon={icon} color={color}