Make Label Cursor Hoverable #3332
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I think the label should only be hoverable for "Unavailable" and any other labels where we are showing a popover. There are no actions for "Available" and "Progressing" AFAIR - so no use making it hoverable(and confusing the users). Also, I think it's a bad practice to use void 0(makes it inaccessible for screen readers- reference link) Can we use a button instead? - I think button is hoverable by default.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3332 +/- ##
==========================================
+ Coverage 84.80% 84.82% +0.02%
==========================================
Files 1315 1315
Lines 29491 29499 +8
Branches 8056 8063 +7
==========================================
+ Hits 25009 25024 +15
+ Misses 4482 4475 -7
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@manaswinidas Made it hoverable only for the 2 needed statuses. Kept it as Label because of the color prop vs button. addressed the void 0 issue as well |
https://issues.redhat.com/browse/RHOAIENG-13047
Description
Made the labels indicate they are hoverable in Settings page
Screen.Recording.2024-10-14.at.3.47.21.PM.mov
How Has This Been Tested?
On the UI
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main