-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approve a PR by leaving "/lgtm" comment #153
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: lugi0 <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing /lgtm
The following are automatically added/executed:
Available user actions:
Supported labels{'/wip', '/verified', '/hold', '/lgtm'} |
Signed-off-by: lugi0 <[email protected]>
Signed-off-by: lugi0 <[email protected]>
see lugi0#2 for testing of the workflow |
on: | ||
workflow_dispatch: #manual testing | ||
issue_comment: | ||
types: [created] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add condition to trigger only if "lgtm in comment"
e/g
if: |
contains(github.event.comment.body, '/lgtm')
also should be triggered on edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actions already checks if /lgtm is int he comment: https://github.com/opendatahub-io/opendatahub-tests/pull/153/files#diff-8adeafbcbe79cc05a3ae753fd95a88451697a3356e53b468f8a7f565c5c737d1R13
Why would we edit a comment to add a lgtm? that seems unlikely to be honest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- i think adding the check on the content of the comment at the top makes it more clear
- a user can edit a comment and add "lgtm"
Signed-off-by: lugi0 <[email protected]>
Description
This add a GHA to approve a PR when a user leaves a "/lgtm" comment
How Has This Been Tested?
Merge criteria: