Skip to content

Commit

Permalink
fix(build): propagate RELEASE_TAG to buildx container
Browse files Browse the repository at this point in the history
Signed-off-by: shubham <[email protected]>
  • Loading branch information
shubham14bajpai authored and kmova committed Nov 12, 2020
1 parent c76197f commit 5849acc
Show file tree
Hide file tree
Showing 6 changed files with 26 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Makefile.buildx.mk
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# ==============================================================================
# Build Options

export DBUILD_ARGS=--build-arg DBUILD_DATE=${DBUILD_DATE} --build-arg DBUILD_REPO_URL=${DBUILD_REPO_URL} --build-arg DBUILD_SITE_URL=${DBUILD_SITE_URL}
export DBUILD_ARGS=--build-arg DBUILD_DATE=${DBUILD_DATE} --build-arg DBUILD_REPO_URL=${DBUILD_REPO_URL} --build-arg DBUILD_SITE_URL=${DBUILD_SITE_URL} --build-arg RELEASE_TAG=${RELEASE_TAG} --build-arg BRANCH=${BRANCH}

ifeq (${TAG}, )
export TAG=ci
Expand Down
6 changes: 5 additions & 1 deletion buildscripts/admission-server/admission-server.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
# limitations under the License.
FROM golang:1.14.7 as build

ARG RELEASE_TAG
ARG BRANCH
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT=""
Expand All @@ -22,7 +24,9 @@ ENV GO111MODULE=on \
GOARCH=${TARGETARCH} \
GOARM=${TARGETVARIANT} \
DEBIAN_FRONTEND=noninteractive \
PATH="/root/go/bin:${PATH}"
PATH="/root/go/bin:${PATH}" \
RELEASE_TAG=${RELEASE_TAG} \
BRANCH=${BRANCH}

WORKDIR /go/src/github.com/openebs/maya/

Expand Down
6 changes: 5 additions & 1 deletion buildscripts/apiserver/apiserver.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
# limitations under the License.
FROM golang:1.14.7 as build

ARG RELEASE_TAG
ARG BRANCH
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT=""
Expand All @@ -22,7 +24,9 @@ ENV GO111MODULE=on \
GOARCH=${TARGETARCH} \
GOARM=${TARGETVARIANT} \
DEBIAN_FRONTEND=noninteractive \
PATH="/root/go/bin:${PATH}"
PATH="/root/go/bin:${PATH}" \
RELEASE_TAG=${RELEASE_TAG} \
BRANCH=${BRANCH}

WORKDIR /go/src/github.com/openebs/maya/

Expand Down
6 changes: 5 additions & 1 deletion buildscripts/cstor-pool-mgmt/cstor-pool-mgmt.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
ARG BASE_IMAGE
FROM golang:1.14.7 as build

ARG RELEASE_TAG
ARG BRANCH
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT=""
Expand All @@ -23,7 +25,9 @@ ENV GO111MODULE=on \
GOARCH=${TARGETARCH} \
GOARM=${TARGETVARIANT} \
DEBIAN_FRONTEND=noninteractive \
PATH="/root/go/bin:${PATH}"
PATH="/root/go/bin:${PATH}" \
RELEASE_TAG=${RELEASE_TAG} \
BRANCH=${BRANCH}

WORKDIR /go/src/github.com/openebs/maya/

Expand Down
6 changes: 5 additions & 1 deletion buildscripts/cstor-volume-mgmt/cstor-volume-mgmt.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
ARG BASE_IMAGE
FROM golang:1.14.7 as build

ARG RELEASE_TAG
ARG BRANCH
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT=""
Expand All @@ -23,7 +25,9 @@ ENV GO111MODULE=on \
GOARCH=${TARGETARCH} \
GOARM=${TARGETVARIANT} \
DEBIAN_FRONTEND=noninteractive \
PATH="/root/go/bin:${PATH}"
PATH="/root/go/bin:${PATH}" \
RELEASE_TAG=${RELEASE_TAG} \
BRANCH=${BRANCH}

WORKDIR /go/src/github.com/openebs/maya/

Expand Down
7 changes: 5 additions & 2 deletions buildscripts/upgrade/upgrade.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,10 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
ARG BASE_IMAGE
FROM golang:1.14.7 as build

ARG RELEASE_TAG
ARG BRANCH
ARG TARGETOS
ARG TARGETARCH
ARG TARGETVARIANT=""
Expand All @@ -23,7 +24,9 @@ ENV GO111MODULE=on \
GOARCH=${TARGETARCH} \
GOARM=${TARGETVARIANT} \
DEBIAN_FRONTEND=noninteractive \
PATH="/root/go/bin:${PATH}"
PATH="/root/go/bin:${PATH}" \
RELEASE_TAG=${RELEASE_TAG} \
BRANCH=${BRANCH}

WORKDIR /go/src/github.com/openebs/maya/

Expand Down

0 comments on commit 5849acc

Please sign in to comment.