Skip to content

Commit 01c5520

Browse files
feat: initContainers values as list
Signed-off-by: Mike Beaumont <[email protected]>
1 parent 9ed598e commit 01c5520

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ v2.9.0 / TBC
66
- **Fixed Encrypted Volume Cloning**
77
Removed encryption parameters (`-o encryption`, `-o keylocation`, `-o keyformat`) from the `zfs clone` command. These parameters are read-only and cannot be set on clones as they automatically inherit encryption from the parent snapshot.
88
[#675](https://github.com/openebs/zfs-localpv/pull/675)
9+
- **Change helm chart value `initContainers` to list**
10+
Changed the `initContainers` value in the Helm chart from a map to a list to
11+
make ordering easier
12+
[#679](https://github.com/openebs/zfs-localpv/pull/679)
913

1014
---
1115

deploy/helm/charts/templates/zfs-controller.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ spec:
3333
serviceAccountName: {{ .Values.serviceAccount.zfsController.name }}
3434
{{- if .Values.zfsController.initContainers }}
3535
initContainers:
36-
{{- range $key, $value := .Values.zfsController.initContainers }}
37-
- name: {{ $key }}
38-
{{ toYaml $value | indent 10 }}
36+
{{ toYaml .Values.zfsController.initContainers | indent 10 }}
3937
{{- end }}
4038
{{- end }}
4139
containers:

deploy/helm/charts/templates/zfs-node.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@ spec:
3737
hostNetwork: true
3838
{{- if .Values.zfsNode.initContainers }}
3939
initContainers:
40-
{{- range $key, $value := .Values.zfsNode.initContainers }}
41-
- name: {{ $key }}
42-
{{ toYaml $value | indent 10 }}
40+
{{ toYaml .Values.zfsNode.initContainers | indent 10 }}
4341
{{- end }}
4442
{{- end }}
4543
containers:

deploy/helm/charts/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,14 +60,14 @@ zfsNode:
6060
# For example:
6161
# allowedTopologyKeys: "kubernetes.io/hostname,openebs.io/rack"
6262
allowedTopologyKeys: "All"
63-
initContainers: {}
63+
initContainers: []
6464
additionalVolumes: {}
6565

6666
# zfsController contains the configurables for
6767
# the zfs controller deployment
6868
zfsController:
6969
componentName: openebs-zfs-controller
70-
initContainers: {}
70+
initContainers: []
7171
additionalVolumes: {}
7272
replicas: 1
7373
resizer:

0 commit comments

Comments
 (0)