Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move XBlock Tutorial to XBlock repo #2206

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

sarina
Copy link
Contributor

@sarina sarina commented Nov 1, 2023

@sarina sarina marked this pull request as draft November 1, 2023 21:15
@sarina sarina marked this pull request as ready for review November 1, 2023 21:19

redirects = {
## TODO
"*": "https://docs.openedx.org/en/latest/developers/references/developer_guide/$source.html",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xblock docs will be available under this url: https://docs.openedx.org/projects/xblock/en/latest/ so I think we'll want the redirect to be somewhere under there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're at https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/index.html so I assume this shoud be https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/$source.html?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this so they're also published under the docs.openedx.org domain here: https://docs.openedx.org/projects/xblock/en/latest/xblock-tutorial/index.html

The docs.openedx.org domain version is the same content but at a more correct location.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @feanil added that in

@sarina sarina force-pushed the sarina/move-xblock-tutorial branch 2 times, most recently from 3704a36 to de0310e Compare November 14, 2023 20:04
@sarina sarina enabled auto-merge (rebase) November 14, 2023 20:41
@sarina sarina force-pushed the sarina/move-xblock-tutorial branch from de0310e to 0b4fed1 Compare November 15, 2023 02:20
@sarina sarina disabled auto-merge November 15, 2023 02:25
@sarina sarina closed this Nov 15, 2023
@sarina sarina reopened this Nov 15, 2023
@sarina
Copy link
Contributor Author

sarina commented Nov 15, 2023

@feanil do you know why the two checks aren't running (docs/readthedocs.org:edx-developer-guide and open-edx-release-notes)? We moved both of those guides anyway so shouldn't we remove these checks?

@feanil
Copy link
Contributor

feanil commented Nov 15, 2023

Looks like those two checks are required in GitHub but maybe no longer setup. I agree that they should just be removed from the set of required checks.

@sarina
Copy link
Contributor Author

sarina commented Nov 15, 2023

Hmm. I tried removing them from run_tests.sh but that didn't make the build icon go away (still says it's "expected"). I'm not sure how to disable the check otherwise.

@feanil
Copy link
Contributor

feanil commented Nov 16, 2023

Oh yea the update is in the github settings but it looks like this is actually related to a new change on the RTD side, I'm fixing that now.

@sarina
Copy link
Contributor Author

sarina commented Nov 16, 2023

Should I back this commit out? 140ab26

@feanil
Copy link
Contributor

feanil commented Nov 20, 2023

Yea, you should remove that commit, I think it's still good to test the redirect builds are working as expected and should be pretty fast.

@sarina sarina force-pushed the sarina/move-xblock-tutorial branch from 140ab26 to bbb88e5 Compare November 20, 2023 16:39
@sarina sarina force-pushed the sarina/move-xblock-tutorial branch from bbb88e5 to 4185bd8 Compare November 20, 2023 16:40
@sarina sarina merged commit 0d98ea7 into master Nov 20, 2023
1 check passed
@sarina sarina deleted the sarina/move-xblock-tutorial branch November 20, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants