-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move XBlock Tutorial to XBlock repo #2206
Conversation
en_us/xblock-tutorial/conf.py
Outdated
|
||
redirects = { | ||
## TODO | ||
"*": "https://docs.openedx.org/en/latest/developers/references/developer_guide/$source.html", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The xblock docs will be available under this url: https://docs.openedx.org/projects/xblock/en/latest/ so I think we'll want the redirect to be somewhere under there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're at https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/index.html so I assume this shoud be https://edx.readthedocs.io/projects/xblock/en/latest/xblock-tutorial/$source.html
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this so they're also published under the docs.openedx.org domain here: https://docs.openedx.org/projects/xblock/en/latest/xblock-tutorial/index.html
The docs.openedx.org domain version is the same content but at a more correct location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @feanil added that in
3704a36
to
de0310e
Compare
de0310e
to
0b4fed1
Compare
@feanil do you know why the two checks aren't running (docs/readthedocs.org:edx-developer-guide and open-edx-release-notes)? We moved both of those guides anyway so shouldn't we remove these checks? |
Looks like those two checks are required in GitHub but maybe no longer setup. I agree that they should just be removed from the set of required checks. |
Hmm. I tried removing them from |
Oh yea the update is in the github settings but it looks like this is actually related to a new change on the RTD side, I'm fixing that now. |
Should I back this commit out? 140ab26 |
Yea, you should remove that commit, I think it's still good to test the redirect builds are working as expected and should be pretty fast. |
140ab26
to
bbb88e5
Compare
bbb88e5
to
4185bd8
Compare
@feanil - depends on openedx/XBlock#686