Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for Xpert course translations #2266

Merged
merged 5 commits into from
Jun 10, 2024

Conversation

nsprenkle
Copy link
Contributor

@nsprenkle nsprenkle commented Jun 5, 2024

Add documents for Xpert course translations
JIRA: https://2u-internal.atlassian.net/browse/AU-1998

Date Needed (optional)

ASAP

Reviewers

Possible roles follow. The PR submitter checks the boxes after each reviewer finishes and gives 👍.

Testing

  • Ran ./run_tests.sh without warnings or errors

Post-review

  • Add a comment with the description of this change or link this PR to the next release notes task.
  • Squash commits

Copy link
Contributor

@jristau1984 jristau1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regrettably, the images will likely all need to be updated with new versions before launch.

@nsprenkle nsprenkle requested a review from jristau1984 June 7, 2024 16:03
@nsprenkle
Copy link
Contributor Author

@jristau1984 , updated with @Daniel-hershel , ready for re-review 👀

@nsprenkle nsprenkle force-pushed the nsprenkle/xpert-translations branch from eff8d4d to b6bf1b9 Compare June 10, 2024 16:51
Copy link
Contributor

@jristau1984 jristau1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nsprenkle nsprenkle merged commit f3fe7ad into master Jun 10, 2024
9 checks passed
@nsprenkle nsprenkle deleted the nsprenkle/xpert-translations branch June 10, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants