Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin importlib-metadata #407

Closed
timmc-edx opened this issue Mar 12, 2024 · 4 comments
Closed

Unpin importlib-metadata #407

timmc-edx opened this issue Mar 12, 2024 · 4 comments

Comments

@timmc-edx
Copy link
Contributor

In #406 we pinned importlib-metadata to before 7.x. Once open-telemetry/opentelemetry-python#3570 resolves we should unpin this.

This pin is in place because we want to use opentelemetry from edx-django-utils. Normally this could be added as a constraint in edx-django-utils, where we're adding the opentelemetry dependency. However, when we compile pip-tools.txt in dependent IDA repos, that layer ends up using version 7.x, and then there's no undoing that when compiling base.txt. So we need to pin it globally, for now.

@zameel7
Copy link
Contributor

zameel7 commented Aug 10, 2024

@timmc-edx, can we unpin this now? Seems like open-telemetry/opentelemetry-python#3570 is resolved.

@zameel7 zameel7 mentioned this issue Aug 10, 2024
6 tasks
@timmc-edx
Copy link
Contributor Author

Ah yes, thank you! I had forgotten to subscribe to that issue.

@zameel7
Copy link
Contributor

zameel7 commented Aug 11, 2024

Ah yes, thank you! I had forgotten to subscribe to that issue.

Any time! Hope we can close this issue now. @timmc-edx

@timmc-edx
Copy link
Contributor Author

Oh yeah, we can! Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants