Skip to content

docs: allow a taxonomy- or course-scoped CompetencyRuleProfile to be deleted with its taxonomy or course - #805

Open
mgwozdz-unicon wants to merge 1 commit into
openedx:mainfrom
mgwozdz-unicon:cbe-rule-profile-taxonomy-delete-adr
Open

docs: allow a taxonomy- or course-scoped CompetencyRuleProfile to be deleted with its taxonomy or course#805
mgwozdz-unicon wants to merge 1 commit into
openedx:mainfrom
mgwozdz-unicon:cbe-rule-profile-taxonomy-delete-adr

Conversation

@mgwozdz-unicon

Copy link
Copy Markdown
Contributor

Jesper pointed out on #613 that pinning CompetencyRuleProfile.competency_taxonomy to PROTECT would block deleting a taxonomy just because a rule profile happens to be scoped to it, even if nothing actually depends on that profile. This amends ADR-0002 Decision 7 so a taxonomy- or course-scoped CompetencyRuleProfile is deleted along with its taxonomy or course instead of blocking the delete.

This is safe because a taxonomy or course is only ever hard-deleted once nothing beneath it needs protecting (Decision 7 already guarantees that), so there's nothing left for the profile's archive-only retirement to protect at that point either.

…deleted with its taxonomy or course

Pinning CompetencyRuleProfile's scope FKs to PROTECT blocked deleting a
taxonomy or course purely because a rule profile happened to be scoped
to it, even with no learner status anywhere beneath it. A taxonomy or
course is only ever hard-deleted once nothing beneath it needs
protecting, so a profile scoped to it is safe to remove at the same
time instead of blocking the delete.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 4, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @mgwozdz-unicon!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Needs Triage

Development

Successfully merging this pull request may close these issues.

2 participants