docs: allow a taxonomy- or course-scoped CompetencyRuleProfile to be deleted with its taxonomy or course - #805
Conversation
…deleted with its taxonomy or course Pinning CompetencyRuleProfile's scope FKs to PROTECT blocked deleting a taxonomy or course purely because a rule profile happened to be scoped to it, even with no learner status anywhere beneath it. A taxonomy or course is only ever hard-deleted once nothing beneath it needs protecting, so a profile scoped to it is safe to remove at the same time instead of blocking the delete.
|
Thanks for the pull request, @mgwozdz-unicon! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Jesper pointed out on #613 that pinning
CompetencyRuleProfile.competency_taxonomytoPROTECTwould block deleting a taxonomy just because a rule profile happens to be scoped to it, even if nothing actually depends on that profile. This amends ADR-0002 Decision 7 so a taxonomy- or course-scopedCompetencyRuleProfileis deleted along with its taxonomy or course instead of blocking the delete.This is safe because a taxonomy or course is only ever hard-deleted once nothing beneath it needs protecting (Decision 7 already guarantees that), so there's nothing left for the profile's archive-only retirement to protect at that point either.