Commit b70557d
refactor: migrate ENABLE_INSTRUCTOR_EMAIL and REQUIRE_COURSE_EMAIL_AUTH off FEATURES-as-dict
Three bulk_email test classes carried
`@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True,
'REQUIRE_COURSE_EMAIL_AUTH': False})`. Neither FEATURES key is read
anywhere in the platform or the installed packages anymore — bulk email
enablement is now governed by the BulkEmailFlag waffle flag and the
CourseAuthorization model — so these class-level overrides are vestigial
no-ops (and, being class-level `patch.dict`, only ever wrapped the
`test_*` methods, not setUp).
Both flags sit in a single decorator dict, so they migrate together:
convert to `@override_settings(ENABLE_INSTRUCTOR_EMAIL=True,
REQUIRE_COURSE_EMAIL_AUTH=False)`. Behavior is unchanged (still unread);
this just removes the FEATURES-dict usage. The classes subclass
SharedModuleStoreTestCase, so the class-level override_settings is valid.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent 9945300 commit b70557d
1 file changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
| 185 | + | |
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
| 213 | + | |
214 | 214 | | |
215 | 215 | | |
216 | 216 | | |
| |||
268 | 268 | | |
269 | 269 | | |
270 | 270 | | |
271 | | - | |
| 271 | + | |
272 | 272 | | |
273 | 273 | | |
274 | 274 | | |
| |||
0 commit comments