Testing and quality upgrades (#123)

* Change to pytest, pycodestyle, upgrade quality
* Add isort and tweak quality / coverage settings
* Fix quality issues, upgrade edx-lint, remove unused lint disables

Author: bmedx

.coveragerc

@@ -1,3 +1,6 @@
 [run]
 branch = True
 source = .
+omit =
+    workbench/test/*
+    sample_xblocks/*/test/*

.gitignore

@@ -5,7 +5,9 @@ local_settings.py
 *.egg-info
 .treerc
 .coverage
+.idea
 .tox
+.pytest_cache
 htmlcov
 geckodriver.log
 

.isort.cfg

@@ -0,0 +1,9 @@
+[settings]
+line_length = 120
+skip = migrations
+known_edx =
+known_django = django
+known_first_party =
+    workbench
+    sample_xblocks
+sections = FUTURE,STDLIB,THIRDPARTY,DJANGO,DJANGOAPP,EDX,FIRSTPARTY,LOCALFOLDER

.pep8

@@ -10,7 +10,6 @@ python:
 
 env:
   - TOXENV=py27-django18
-  - TOXENV=py27-django110
   - TOXENV=py27-django111
 
 matrix:
@@ -26,23 +25,23 @@ cache:
         - $HOME/.cache/pip
 
 before_script:
-    - "export DISPLAY=:99.0"
-    - "sh -e /etc/init.d/xvfb start"
-    - "sleep 3" # give xvfb some time to start
+    - export DISPLAY=:99.0
+    - sh -e /etc/init.d/xvfb start
+    - sleep 3 # give xvfb some time to start
 
 before_install:
-    - "wget https://github.com/mozilla/geckodriver/releases/download/v0.15.0/geckodriver-v0.15.0-linux64.tar.gz"
-    - "mkdir geckodriver"
-    - "tar -xzf geckodriver-v0.15.0-linux64.tar.gz -C geckodriver"
-    - "export PATH=$PATH:$PWD/geckodriver"
-    - "pip install -U pip"
+    - wget https://github.com/mozilla/geckodriver/releases/download/v0.15.0/geckodriver-v0.15.0-linux64.tar.gz
+    - mkdir geckodriver
+    - tar -xzf geckodriver-v0.15.0-linux64.tar.gz -C geckodriver
+    - export PATH=$PATH:$PWD/geckodriver
+    - pip install -U pip
 
 install:
-    - "pip install tox-travis"
+    - pip install tox-travis
+    - pip install -r requirements/tox.txt
 
 script:
     - tox
 
 after_success:
-    - "pip install coveralls"
-    - "coveralls"
+    - codecov

.travis.yml

@@ -26,17 +26,11 @@ $(SQLITE_DB): var
 
 .PHONY: test
 test:
-	python manage.py test
+	tox
 
 .PHONY: quality
 quality:
-	pep8
-	pylint workbench/ sample_xblocks/ setup.py
-
-.PHONY: cover
-cover:
-	coverage run manage.py test
-	coverage report
+	tox -e quality
 
 clean:
 	rm -f workbench.log* workbench.test.*

Makefile

@@ -0,0 +1,12 @@
+coverage:
+  status:
+    project:
+      default:
+        enabled: yes
+        target: auto
+    patch:
+      default:
+        enabled: yes
+        target: 85%
+
+comment: false