Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing branches in grid model #96

Closed
nesnoj opened this issue Nov 16, 2017 · 10 comments
Closed

missing branches in grid model #96

nesnoj opened this issue Nov 16, 2017 · 10 comments
Assignees
Labels

Comments

@nesnoj
Copy link
Member

nesnoj commented Nov 16, 2017

Not sure if this is the right repo, but:
I found some 110kV-lines which obviously exist but are not included in the table grid.otg_ehvhv_branch_data near "UW Jessen Nord" (bus_i = 28061 in table grid.otg_ehvhv_bus_data). They should be connected to branch 21026..

osmtgmod_bug1

This might be interesting for you..

@nesnoj
Copy link
Member Author

nesnoj commented Nov 16, 2017

Oh, this EHV/HV substation was installed in 2016, probably it wasn't included in the OSM data used by osmTGmod?!

@lukasoldi
Copy link
Contributor

Probably. our osm data is still dated 2016-10-01...

@nesnoj
Copy link
Member Author

nesnoj commented Nov 16, 2017

Ok.
Is an OSM update already scheduled? @Ludee

@Ludee
Copy link
Member

Ludee commented Nov 16, 2017

Planed but not scheduled!
How important/ urgent is it?

I can help organising but @gnn will have to execute it in Magdeburg.

@nesnoj
Copy link
Member Author

nesnoj commented Nov 16, 2017

It is not very urgent but it'd be great to have recent data by the end of this year..

@nesnoj
Copy link
Member Author

nesnoj commented Nov 17, 2017

ok, I close this one and get back to you later..

@nesnoj nesnoj closed this as completed Nov 17, 2017
@nesnoj
Copy link
Member Author

nesnoj commented Feb 2, 2018

I need a current HV dataset asap. Anything new about the OSM update?

If not, I'd fix it manually for my specific application since a manual update of all related/derived eGo-tables was (at least for me) not fail-safe at all..
Related: #97

@nesnoj nesnoj reopened this Feb 2, 2018
@IlkaCu
Copy link
Member

IlkaCu commented Feb 5, 2018

During our last project meeting we decided to stay with the current OSM data set until we finish the project. Would that be okay for you?
@ClaraBuettner already described and fixed some other topology errors for the EHV level in this issue. Would it be possible to include a similar 'manual' bug fix in the DP for your case?

@nesnoj
Copy link
Member Author

nesnoj commented Feb 5, 2018

Thanks for getting back to me. A manual bugfix would suit my needs..

I fixed this 110 KV issue manually by adding these new lines without touching the original DP tables (as mentioned above, I do not want to break your model). I'm ok since it works for me.. But if it is crucial for eGo, @ClaraBuettner may fix it in the eGo tables..?!

My solution
Notes:

  • I fixed it in derived bus and line tables, not the osmTGmod ones
  • my table names hold the prefix "wn_"
  • line geoms are straight lines (geom and topo column)
  • I used the OSM node id as bus id for the 2 new buses
  • electrical properties were calculated manually using existing data for 110kV (avg of specific x,r,g,b (per km) for this type)
-- 1a) Insert 2 missing buses on 110kV line
INSERT INTO model_draft.wn_abw_ego_pf_hv_bus
    (version, bus_id, v_nom, geom, hvmv_subst_id, in_region)
  VALUES
    ('v0.3.0', 1851699628, 110, ST_SetSRID(ST_Point(13.0317764, 51.7792147), 4326), 2482, True),
    ('v0.3.0', 1851699629, 110, ST_SetSRID(ST_Point(13.0289850, 51.7797518), 4326), 2482, True)
;

-- 1b) Lines from substation (Jessen Nord) buses to buses
INSERT INTO model_draft.wn_abw_ego_pf_hv_line
    (version, line_id, bus0, bus1, x, r, g, b, s_nom, length, cables, frequency, geom, topo)
  VALUES
    ('v0.3.0', 461202177, 28063, 1851699628, 0.6138, 0.17754, 0, 0.000019455, 520, 3.3, 6, 50, 
      (SELECT ST_SetSRID(ST_Multi(ST_MakeLine(bus.geom)), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699628, 28063)),
      (SELECT ST_SetSRID(ST_MakeLine(bus.geom), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699628, 28063))
    ),
    ('v0.3.0', 461202186, 28063, 1851699629, 0.6138, 0.17754, 0, 0.000019455, 520, 3.3, 6, 50, 
      (SELECT ST_SetSRID(ST_Multi(ST_MakeLine(bus.geom)), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699629, 28063)),
      (SELECT ST_SetSRID(ST_MakeLine(bus.geom), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699629, 28063))
    )
;

-- 1c) Split and reconfigure existing 110kV line
UPDATE model_draft.wn_abw_ego_pf_hv_line
  SET
    bus1 = 1851699628,
    length = 15.9,
    x = 6,
    r = 1.735,
    b = 0.0000475,
    geom = (SELECT ST_SetSRID(ST_Multi(ST_MakeLine(bus.geom)), 4326)
              FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
              WHERE bus.bus_id in (20759, 1851699628)),
    topo = (SELECT ST_SetSRID(ST_MakeLine(bus.geom), 4326)
              FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
              WHERE bus.bus_id in (20759, 1851699628))
  WHERE line_id = 21026
;

INSERT INTO model_draft.wn_abw_ego_pf_hv_line
    (version, line_id, bus0, bus1, x, r, g, b, s_nom, length, cables, frequency, geom, topo)
  VALUES
    ('v0.3.0', 99999999990, 1851699628, 1851699629, 0.0755, 0.0218, 0, 0.000000597, 260, 0.2, 3, 50, 
      (SELECT ST_SetSRID(ST_Multi(ST_MakeLine(bus.geom)), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699628, 1851699629)),
      (SELECT ST_SetSRID(ST_MakeLine(bus.geom), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699628, 1851699629))
    ),
    ('v0.3.0', 99999999991, 1851699629, 25600, 1.547, 0.447, 0, 0.000012249, 260, 4.1, 3, 50, 
      (SELECT ST_SetSRID(ST_Multi(ST_MakeLine(bus.geom)), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699629, 25600)),
      (SELECT ST_SetSRID(ST_MakeLine(bus.geom), 4326)
         FROM model_draft.wn_abw_ego_pf_hv_bus AS bus
         WHERE bus.bus_id in (1851699629, 25600))
    )
;

I am not sure if this involves all required modifications?! I'd appreciate your comments :)

The second bug #97 is related to eHV..

@IlkaCu
Copy link
Member

IlkaCu commented Mar 19, 2018

I close this issue as this is not the right place for it. Further discussions take place in open_ego/dataprocessing #207.

@IlkaCu IlkaCu closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants