Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3-protobuf not ussing cpp backend. #802

Open
sreinartz opened this issue Mar 19, 2024 · 0 comments
Open

python3-protobuf not ussing cpp backend. #802

sreinartz opened this issue Mar 19, 2024 · 0 comments

Comments

@sreinartz
Copy link

Issue:
The current implementation of the python3-protobuf recipe has 2 issues. Tested this in Kirkstone release. At least problem one occurs in other releases, too.

1: The python3-protobuf recipe is using the Python backend which is very slow and should NOT be the default for protobuf. https://github.com/protocolbuffers/protobuf/tree/main/python#implementation-backends.
The current recipe is intended to use the cpp backend: https://github.com/openembedded/meta-openembedded/blob/kirkstone/meta-python/recipes-devtools/python/python3-protobuf_3.20.3.bb#L34
But this doesn't work! I tried to fix it locally by adding
SETUPTOOLS_BUILD_ARGS:append = " --cpp_implementation" to the recipe the the next error occurs

2: Both recipes
Python: https://github.com/openembedded/meta-openembedded/blob/kirkstone/meta-python/recipes-devtools/python/python3-protobuf_3.20.3.bb
cpp: https://github.com/openembedded/meta-openembedded/blob/kirkstone/meta-oe/recipes-devtools/protobuf/protobuf_3.19.6.bb
have different versions and don't work together. They need to point to the same version to get the cpp backend working.

Expected result:
Python protobuf should use cpp backend as default. To make this happen, we need to fix the dependency and make sure to provide same versions for both Python and cpp in a yocto released version.

thomas-roos pushed a commit to thomas-roos/meta-openembedded that referenced this issue May 2, 2024
This release contains bug fixes only.
The following CVEs have been addressed:

CVE-2023-27783
CVE-2023-27784
CVE-2023-27785
CVE-2023-27786
CVE-2023-27787
CVE-2023-27788
CVE-2023-27789

Changelog:
=========
dlt_jnpr_ether_cleanup: check subctx before cleanup by @Marsman1996 in openembedded#781
Bug openembedded#780 assert tcpedit dlt cleanup by @fklassen in openembedded#800
Fix bugs caused by strtok_r by @Marsman1996 in openembedded#783
Bug openembedded#782 openembedded#784 openembedded#785 openembedded#786 openembedded#787 openembedded#788 strtok r isuses by @fklassen in openembedded#801
Update en10mb.c by @david-guti in openembedded#793
PR openembedded#793 ip6 unicast flood by @fklassen in openembedded#802
Bug openembedded#719 fix overflow check for parse_mpls() by @fklassen in openembedded#804
PR openembedded#793 - update tests for corrected IPv6 MAC by @fklassen in openembedded#805
PR openembedded#793 - update tests for vlandel by @fklassen in openembedded#806
Feature openembedded#773 gh actions ci by @fklassen in openembedded#807
Feature openembedded#759: Upgrade autogen/libopts to 5.18.16 by @fklassen in openembedded#760
Bug openembedded#751 don't exit after send error by @fklassen in openembedded#761
Bug openembedded#750: configure: libpcap version robustness by @fklassen in openembedded#764
Bug openembedded#749 flow stats: avoid overstating flow packet count by @fklassen in openembedded#765
Bug openembedded#750 more libpcap version updates by @fklassen in openembedded#766
Bug openembedded#767 tests: support for out-of-tree tests by @fklassen in openembedded#768
Bug openembedded#750 - fix macOS test failure by @fklassen in openembedded#770
4.4.3 by @fklassen in openembedded#769 and openembedded#771

Signed-off-by: Archana Polampalli <[email protected]>
Signed-off-by: Armin Kuster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant