Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for retries #22

Open
itsmurugappan opened this issue Apr 16, 2019 · 2 comments
Open

Support for retries #22

itsmurugappan opened this issue Apr 16, 2019 · 2 comments

Comments

@itsmurugappan
Copy link

Issue: Incase the openfaas gateway is down or function does not scale in time from 0 to 1. The messages might be lost.

Proposal: While calling the gateway is it a good idea to add retries and on multiple failures add the message back to the queue.

@alexellis
Copy link
Member

alexellis commented Apr 16, 2019

Hi thanks for the suggestion.

I'm happy to explore this idea. There are a number of ways it can be achieved:

  • at the publisher/client
  • in the individual connector implementation
  • in this SDK generically
  • in the gateway
  • through use of a service mesh or proxy (envoy for instance can be set to automatically retry)

@itsmurugappan
Copy link
Author

Thank you Alex.

  • In this sdk, retries can be added for function calls for non 200 responses.
  • In the connector implementation, failure message can be added back to the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants