Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] Add ReadFromEnv for the controller config #49

Open
2 of 3 tasks
LucasRoesler opened this issue Dec 27, 2019 · 0 comments
Open
2 of 3 tasks

[Proposal] Add ReadFromEnv for the controller config #49

LucasRoesler opened this issue Dec 27, 2019 · 0 comments

Comments

@LucasRoesler
Copy link
Member

My actions before raising this issue

I would like to propose adding a Read/GetFromEnv to the connector-sdk here https://github.com/openfaas-incubator/connector-sdk/blob/df5d76475412b74c3516ba912ae4522793780994/types/controller.go#L17 similar to how we did it in the faas-provider https://github.com/openfaas/faas-provider/blob/d6579bdcf7c85f4d01f398d65ea0cab37e9633d0/types/read_config.go#L77 , so that PRs like this openfaas/nats-connector#3 that copy the config from one location to another are not needed. If you update the SDK and the config changes, the propogation of the new config should be automatic. Copying config from one struct to another going to to be bug prone.

This would make configuration consistent in the various connectors and simplify upgrades downstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LucasRoesler