Release v5.0.0 Grünkohl

[rioug]

1. Preparation on Thursday

• Merge pull requests in the Ready To Go column
• Include translations: script/release/update_locales
  • You need the Transifex Client installed on your local dev environement to run the script.
• Increment version number: git push upstream HEAD:refs/tags/vX.Y.Z
  • Major: if server changes are required (eg. provision with ofn-install)
  • Minor: larger change that is irreversible (eg. migration deleting data)
  • Patch: all others. Shortcut: script/release/tag
• Draft new release. Look at previous releases for inspiration.
  • Select new release tag
  • Generate release notes and check to ensure all items are arranged in the right category.
• Notify #instance-managers of user-facing 👀, API ⚠️ and experimental 🚧 changes.

2. Testing

• Move this issue to Test Ready.
• Notify @testers in #testing.
• Test build: Deploy to Staging with release tag.

3. Finish on Tuesday

• Publish and notify #global-community (this is automatically posted with a plugin)
• Deploy the new release to all managed instances.
  Command line instructions

  cd ofn-install
  git pull
  ansible-playbook --limit all_prod --extra-vars "git_version=vX.Y.Z" playbooks/deploy.yml
  

• Notify #instance-managers:

  @instance_managers The new release has been deployed.

• Create issue for next release and confirm with next release manager in #core-devs.

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

[mkllnk]

I created another tag in between again. You'll need to adjust the release note generation to the last official release tag v4.6.11.

[filipefurtad0]

Hey @rioug ,

I've tested the release, and the usual test cases show no issues, all good here:
https://docs.google.com/document/d/1IkUr7Fcipzr5oCggC7c03nzcqS3rG9XZdTKCx5Z-zZQ/edit?tab=t.0

However, I thought I'd have a look in the products page, given we're rolling out a big chunk. Unfortunately, it can be seen, that after staging this PR, new products/variants (1, pic below) retain the attributed unit scale but previously created products/variants (2, pic below) are left without a unit scale. Interestingly, it appears ok in the shopfrot:

I've checked the DB and it looks like the issue is not only on the UI, variant_unit_scale is NULL for variant 2):

For variant 1):

openfoodnetwork=> select variant_unit, variant_unit_scale, unit_value from spree_variants where id = 158192;
 variant_unit | variant_unit_scale | unit_value 
--------------+--------------------+------------
 weight       |               1000 |      22000

For variant 2)

openfoodnetwork=> select variant_unit, variant_unit_scale, unit_value from spree_variants where id = 158187;
 variant_unit | variant_unit_scale | unit_value 
--------------+--------------------+------------
 weight       |                    |       1000
(1 row)

I don't know why, but this was (and is, as of now) not observed in staging-AU, where the PR #12787 was tested:

I'm afraid this release might be removing unit scale from all variants, so I'd mark it as blocked, for now. I'm a bit puzzled by this, I'd expect this to have been seen in staging-AU, before.

Happy for your thoughts on this.

EDIT: I realize we have discussed a similar situation, but to my understanding there are two distinct situations:

• if the UI displays the option to select an empty value -> release is not blocked, as per this comment and issue.
• if unit scale values are removed from previously existing variants -> release is blocked

I'll delete the migrations, re-stage, and check again.

[filipefurtad0]

After deleting the migrations with:

bundle exec rails db:migrate:down VERSION=20240819045115
bundle exec rails db:migrate:down VERSION=20240618013850

and re-staging the PR, we get the following result:

Variant 1) (from the pic in the previous comment) now has an empty variant_unit_scale:

openfoodnetwork=> select variant_unit, variant_unit_scale, unit_value from spree_variants where id = 158192;
 variant_unit | variant_unit_scale | unit_value 
--------------+--------------------+------------
 weight       |                    |      22000
(1 row)

Variant 2) now has the correct information an empty variant_unit_scale:

openfoodnetwork=> select variant_unit, variant_unit_scale, unit_value from spree_variants where id = 158187;
 variant_unit | variant_unit_scale | unit_value 
--------------+--------------------+------------
 weight       |               1000 |       1000
(1 row)

With an empty (mandatory) value, no changes can be made to the page. I think this might render the page unusable.

So, I'm not sure we're good here. Can you confirm @rioug @RachL ?

[rioug]

I think the database was a bit out of sync, probably because the PR was staged on the server but the migration were never reverted before this release was staged.

I reverted the migration using :

bundle exec rails db:migrate:down VERSION=20240819045115
bundle exec rails db:migrate:down VERSION=20240618013850

I then staged the current release and set up some test data :

After staging v5.0.0 I can see the unit scale are correct :