Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inform users they need to unblock 3rd party browser cookies in Firefox to make /map work #8230

Open
luisramos0 opened this issue Apr 14, 2020 · 7 comments · May be fixed by #12963
Open

Inform users they need to unblock 3rd party browser cookies in Firefox to make /map work #8230

luisramos0 opened this issue Apr 14, 2020 · 7 comments · May be fixed by #12963
Assignees
@MichaelDimmitt @murjax
Labels
enhancement improvement

Comments

@luisramos0
Copy link
Contributor

Description

Currently if user has disabled 3rd party cookies, for example in Firefox:
image

When the user goes to /map the map wont show correctly
image

And bugsnagJS errors will be created like:
https://app.bugsnag.com/yaycode/open-food-network-js-katuma/errors/5e8c6364df4e9c0017b280c6?filters[event.since][0]=30d&filters[error.status][0]=open
image

But the user is not informed about this error in any way. So for the user, the OFN map is broken.

We could make a very simple change in OFN to detect this problem and show an error message to the user indicating they should enable third-party cookies if they want to see the OFN map.

All occurrences of this error in bugsnagJS (121 in France) are on Firefox, so this is a Firefox specific issue. The map works correctly in chrome even if 3rd party cookies are disabled.

Acceptance Criteria & Tests

Users who have disabled 3rd party cookies are warned when they visit /map that they can enable 3rd party cookies to see the map.
@luisramos0 luisramos0 changed the title Inform users they need to unblock third party cookies to make /maps work Inform users they need to unblock 3rd party browser cookies to make /map work Apr 14, 2020
@luisramos0
Copy link
Contributor Author

luisramos0 commented Apr 14, 2020 •
edited
Loading

I tested this in multiple staging and prod servers and it doesnt happen always, in many cases the error is triggered but for some reason the page still works..

@luisramos0
Copy link
Contributor Author

In 1 week of bugsnagJS, this error was seen in the browser of 102 users in France, 20 users in AUS and 16 users in UK.

@luisramos0
Copy link
Contributor Author

luisramos0 commented Apr 14, 2020 •
edited
Loading

there is another bugsnagJS error that affects 182 users in FR:
image

I cant replicate this one. This one happens in 10 different browsers.

@luisramos0 luisramos0 changed the title Inform users they need to unblock 3rd party browser cookies to make /map work Inform users they need to unblock 3rd party browser cookies in Firefox to make /map work Apr 14, 2020
@Matt-Yorkley
Copy link
Contributor

Could be a specific browser plugin? I use several for blocking ads and cookies...

@jaycmb jaycmb transferred this issue from openfoodfoundation/openfoodnetwork Jun 9, 2021
@andrewpbrett
Copy link
Contributor

This could take a little digging into how to detect that third party cookies are disabled... this answer looks relevant: https://stackoverflow.com/questions/3550790/check-if-third-party-cookies-are-enabled#7104048

At first glance it looks larger than a papercut.

@RachL RachL transferred this issue from openfoodfoundation/wishlist Sep 24, 2021
@RachL RachL added the Hacktoberfest Issues for upcoming hackathons label Sep 24, 2021
@sigmundpetersen sigmundpetersen added the enhancement improvement label Nov 15, 2021
@mkllnk mkllnk moved this to Frontend Hard in Welcome New Developers! Jan 20, 2023
@github-project-automation github-project-automation bot moved this to All the things in OFN Delivery board Feb 16, 2024
@RachL RachL removed the Hacktoberfest Issues for upcoming hackathons label Oct 1, 2024
@MichaelDimmitt
Copy link
Contributor

MichaelDimmitt commented Oct 30, 2024 •
edited
Loading

What website currently does this? @luisramos0, can you name one for us? I think that would be helpful.
If no other website currently supports this functionality for Firefox.
If a website does currently do this functionality in Firefox. Just shoot to emulate that behavior. cc @murjax

Otherwise, my vote probably does not count but id say, try not to reinvent the wheel. And the issue should just be closed as a browser specific issue.

@murjax
Copy link
Contributor

murjax commented Nov 1, 2024

The TypeError mentioned above is from the search bar and is a downstream effect of the map not rendering. It's reproducible in local development by turning off the network and loading the map page.

Although users would unlikely reach this error in staging or prod via network failure, it does identify an area we can respond and tell the user 3rd party cookie settings may need to be checked. Opening a PR shortly with a potential solution for further discussion.

@murjax murjax linked a pull request Nov 1, 2024 that will close this issue
Open
4 tasks
@sigmundpetersen sigmundpetersen moved this from All the things 💤 to In Progress ⚙ in OFN Delivery board Nov 1, 2024
@sigmundpetersen sigmundpetersen moved this from Frontend Hard to In progress in Welcome New Developers! Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichaelDimmitt MichaelDimmitt

@murjax murjax

Labels
enhancement improvement
Projects
OFN Delivery board
Status: In Progress ⚙
Welcome New Developers!
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show alert if map cannot load murjax/openfoodnetwork
7 participants
@andrewpbrett @sigmundpetersen @luisramos0 @RachL @Matt-Yorkley @MichaelDimmitt @murjax