Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making ElectrostaticsCollection.invalidate_cache #1142

Open
mattwthompson opened this issue Jan 15, 2025 · 0 comments
Open

Consider making ElectrostaticsCollection.invalidate_cache #1142

mattwthompson opened this issue Jan 15, 2025 · 0 comments

Comments

@mattwthompson
Copy link
Member

          Am I right in thinking that this has implications for modifying an `ElectrostaticsCollection` after the charges have been cached? If so, since we demonstrate modifying collections in the examples, we should probably add some sort of `invalidate_cache()` method and document this behavior both in the collection docstring and in the relevant examples. Modifying a collection according to the example and having that modification only sometimes reflected in outputs would be quite frustrating.

Originally posted by @Yoshanuikabundi in #1115 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant