Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Auto Download of Addons via script - the era of packageManagers #479

Open
danoli3 opened this issue Jan 26, 2024 · 2 comments
Open
Assignees

Comments

@danoli3
Copy link
Member

danoli3 commented Jan 26, 2024

I forget this is not built into the project Generator already as I been using it for so long.

https://github.com/danoli3/ofxAddonScript

I suggest we add a new format in addons.make to follow this convention and is run via the projectGenerator and code implemented for this script within the projectGenerator in C++

"ofxAddonScript" "https://github.com/danoli3/ofxAddonScript.git" "78fd6f27cf82743644f0c12f926ae053a42a7aa3"

Modifications to addons.make would allow for such definitions

ofxXmlSettings
ofxTexturePacker https://github.com/danoli3/ofxTexturePacker
ofxShapeBatchRenderer https://github.com/stfj/ofxShapeBatchRenderer 71c2144a501ac80682c81aa20d95d0f07c307453
ofxTextAnimation https://github.com/TetsuakiBaba/ofxTextAnimation master
@danoli3 danoli3 self-assigned this Jan 26, 2024
@dimitre
Copy link
Member

dimitre commented Jan 26, 2024

Hey @danoli3 is this a valid syntax for makefile?
by the way I've been using a personal tool to make reproduceable recipes in projects, including local addons if needed (specific branch or commit)

# name: AV2023

ofpath: ../../..

addons:
- ofxNetwork
- ofxAssimpModelLoader
- ofxMicroUI
- ofxMicroUIMidiController
- ofxTools
- ofxScenes
- ofxSyphon
- ofxMidi

# platforms: ["osx"]
# templates: ["vscode"]

as projectgenerator "rewrites" addons.make and remove not found addons, I've found this is not reliable for reproducing projects.

https://github.com/dimitre/ofbuild

@danoli3
Copy link
Member Author

danoli3 commented Jan 26, 2024

Oh addons.make is not a real make file its interpreted by config.addons.mk so we can do whatever we want to it if we fix up parameters in the parsing of that file in core

Its used by the make system and the projectGenerator

Yeah in projectGenerator if you deleted an addon it would remove it from the addons.make file, but we can put if theres any extra code in it (params) to comment it out maybe to not lose any manually defined remotes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants