[smartthings] WIP Refactor binding to make use of new API #17855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo92fr
force-pushed
the
smartthingsNG
branch
2 times, most recently
from
6e7f0da to
4549915
Compare
lolodomo
added
the
enhancement
lo92fr
force-pushed
the
smartthingsNG
branch
2 times, most recently
from
bd63abb to
d5191d8
Compare
|
Hello Laurent (@lolodomo), Just a little remak. I'm see that BobRak was added as reviewer. I'm don't know if it's an automatic process as it was the creator of the first version of the binding. I'm not sure that Bobrak is still there to follow openhab developpement. The smartthing binding is not working since already two years, and I never see an answer from Bob to the issues. Also notes that there is no activities on his github since 2021. At the best, Bob do not seems to use Openhab anymore... or worst. So we have peharps to thing to find another reviewer for this. Just to let you know, the binding is starting to work quite well.
There is still some issue to be address:
As soon as i Finish to rewrite the documentation, I will try to see on my side if I can find some beta tester that have smarthing device to do some more test. Laurent. |
This was
linked to
issues
Dec 15, 2024
lo92fr
force-pushed
the
smartthingsNG
branch
from
58be23d to
1f52adc
Compare
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
remove template player.html change oauth scope Signed-off-by: Laurent ARNAL <[email protected]>
code cleaning (WIP) Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
WIP will need to implements ThingTypeProvider and ChannelTypeProvider to provide full support Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
fix group naming Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
some fixes on typeRegistry add reading for extended capabilities not in base capabilities listing Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
fix bad event handling because group was wrong on incoming events temp fix class cast exception in Converter Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
lo92fr
force-pushed
the
smartthingsNG
branch
from
1f52adc to
29e6fd7
Compare
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
…etrieve from the apps that is automatically created ! Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
Signed-off-by: Laurent ARNAL <[email protected]>
lsiepel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about rewriting the Smartthings addons that is not working anymore since a few month because of deep change in the samsung API.
This is link to issue : #16946
And also to discussion in communauty forum : https://community.openhab.org/t/smartthings-binding-eol/138750/19
This is currently work in progress.
What is working so far:
To start testing the new binding, you will app to create an oauth token from the following URL : https://account.smartthings.com/tokens/new
OAuth token name is arbitrary, you can set what you want.
For now, select all the scope.
When you have the token, go back to openhab, an fill the Smarthings Cloudhub device with the token.
You can ignore the clientId / clientSecret (put a random value), I will remove them in feature relase.
After that, you will need to go to the uri : http://{myopenhabinstance/smartthings.
You will have, on the second page, to select your smartthings location.
After this, a popup window will open on the Smartthings site.
First page is just about confirming the Smartthings App name, just keep the default and confirm.
Second page is about to confirm device access for openhab, just click confirm.
After this step, you can close the popup window, go back to openhab, and scan your device to inbox.
Notes : smartthings cli installation, and manual smartthings app creation is not need anymore.
All this process is automatic in new version.
Best regards,
Laurent.