-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding esphome dashboard install and uninstall feature #1932
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start, implement the changes suggested here, and double check and compare your code to the other install sequences in the codebase and that should get you most of the rest of the way there.
Also take a look at the error message for DSC Bot on how to properly sign off your commits.
Let me know if you have any questions.
7e7c7f9
to
9e2c6d3
Compare
Rebase the branch If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing"). You should only do this if: You are the only author of the commits in this branch Ensure you have a local copy of your branch by checking out the pull request locally via command line. |
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
9e2c6d3
to
8e11f96
Compare
Signed-off-by: michaelloercher <[email protected]>
Signed-off-by: michaelloercher <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implement the changes to the output on all of the functions.
Additionally, add cond_redirect
to any expressions that will output anything to the console.
Signed-off-by: michaelloercher <[email protected]>
Description:
This pull request adds the ESPHome dashboard installation and uninstallation feature to the OpenHABian setup. The feature allows users to easily install or uninstall the ESPHome dashboard as part of the OpenHABian configuration process.
Changes:
Added a new option to the OpenHABian configuration menu to install the ESPHome dashboard.
Implemented the ability to uninstall the ESPHome dashboard from the system.
Updated related documentation for the new feature.
Why this is needed:
This update provides users with a streamlined way to manage the ESPHome dashboard directly from the OpenHABian setup, improving the ease of use and flexibility for those integrating ESPHome with OpenHAB.
Closes Issue:
Resolves #1904.