From e58b4aaa73bd2a9e4a09cb857995f33f0b96e9a7 Mon Sep 17 00:00:00 2001 From: Cesar Fuguet Date: Thu, 10 Oct 2024 17:43:21 +0200 Subject: [PATCH] pkg: remove obsolete wbufSendFeedThrough config parameter --- rtl/lint/hpdcache_lint.sv | 1 - rtl/src/hpdcache_pkg.sv | 2 -- rtl/src/hpdcache_wbuf.sv | 6 ++---- rtl/tb/hpdcache_wrapper.sv | 1 - 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/rtl/lint/hpdcache_lint.sv b/rtl/lint/hpdcache_lint.sv index 6c2a9db..11fdb54 100644 --- a/rtl/lint/hpdcache_lint.sv +++ b/rtl/lint/hpdcache_lint.sv @@ -57,7 +57,6 @@ module hpdcache_lint wbufDataEntries: 8, wbufWords: 4, wbufTimecntWidth: 3, - wbufSendFeedThrough: 1'b0, rtabEntries: 4, flushEntries: 4, flushFifoDepth: 2, diff --git a/rtl/src/hpdcache_pkg.sv b/rtl/src/hpdcache_pkg.sv index 63b5d74..37543f1 100644 --- a/rtl/src/hpdcache_pkg.sv +++ b/rtl/src/hpdcache_pkg.sv @@ -421,8 +421,6 @@ package hpdcache_pkg; int unsigned wbufWords; // Write-Buffer threshold counter width (in bits) int unsigned wbufTimecntWidth; - // Use feedthrough FIFOs from the write-buffer to the NoC - bit wbufSendFeedThrough; // Number of entries in the replay table int unsigned rtabEntries; // Number of entries in the flush directory diff --git a/rtl/src/hpdcache_wbuf.sv b/rtl/src/hpdcache_wbuf.sv index d270c17..586e892 100644 --- a/rtl/src/hpdcache_wbuf.sv +++ b/rtl/src/hpdcache_wbuf.sv @@ -614,7 +614,7 @@ import hpdcache_pkg::*; hpdcache_fifo_reg #( .FIFO_DEPTH (WBUF_SEND_FIFO_DEPTH), - .FEEDTHROUGH (HPDcacheCfg.u.wbufSendFeedThrough), + .FEEDTHROUGH (1'b0), .fifo_data_t (wbuf_send_data_t) ) send_data_ptr_fifo_i ( .clk_i, @@ -636,7 +636,7 @@ import hpdcache_pkg::*; hpdcache_fifo_reg #( .FIFO_DEPTH (WBUF_SEND_FIFO_DEPTH), - .FEEDTHROUGH (HPDcacheCfg.u.wbufSendFeedThrough), + .FEEDTHROUGH (1'b0), .fifo_data_t (wbuf_send_meta_t) ) send_meta_fifo_i ( .clk_i, @@ -710,8 +710,6 @@ import hpdcache_pkg::*; `ifndef HPDCACHE_ASSERT_OFF initial assert(WBUF_DATA_NWORDS inside {1, 2, 4, 8, 16}) else $fatal("WBUF: width of data buffers must be a power of 2"); - initial assert(HPDcacheCfg.u.wbufSendFeedThrough == 1'b0) else - $fatal("WBUF: wbufSendFeedThrough=1 is currently not supported"); initial assert(WBUF_MEM_DATA_RATIO > 0) else $fatal($sformatf("WBUF: width of mem interface (%d) shall be g.e. to wbuf width(%d)", HPDcacheCfg.u.memDataWidth, HPDcacheCfg.wbufDataWidth)); diff --git a/rtl/tb/hpdcache_wrapper.sv b/rtl/tb/hpdcache_wrapper.sv index 86ad25c..b550c76 100644 --- a/rtl/tb/hpdcache_wrapper.sv +++ b/rtl/tb/hpdcache_wrapper.sv @@ -56,7 +56,6 @@ import hpdcache_pkg::*; wbufDataEntries: `CONF_HPDCACHE_WBUF_DATA_ENTRIES, wbufWords: `CONF_HPDCACHE_WBUF_WORDS, wbufTimecntWidth: `CONF_HPDCACHE_WBUF_TIMECNT_WIDTH, - wbufSendFeedThrough: `CONF_HPDCACHE_WBUF_SEND_FEEDTHROUGH, rtabEntries: `CONF_HPDCACHE_RTAB_ENTRIES, flushEntries: `CONF_HPDCACHE_FLUSH_ENTRIES, flushFifoDepth: `CONF_HPDCACHE_FLUSH_FIFO_DEPTH,