Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the response encryption key remark outside of the new parameters list #176

Closed
yaromin opened this issue May 16, 2024 · 1 comment
Closed

Comments

@yaromin
Copy link
Contributor

yaromin commented May 16, 2024

This fragment cuts the list into two fragments. It is unclear whether the request_uri_method that follows is still part of the same list and why the description of something that is not a new parameter appears here.

A public key to be used by the Wallet as an input to the key agreement to encrypt Authorization Response (see (#jarm)). It MAY be passed by the Verifier using the jwks or the jwks_uri claim within the client_metadata or client_metadata_uri request parameter.

I would reword it slightly ...

If encryption of the Authorization Response is needed, the public key to be used by the Wallet as an input to the key agreement to encrypt Authorization Response (see (#jarm)) MAY be passed by the Verifier using the jwks or the jwks_uri claim in the Client Metadata.

... and move it after the request_uri_method.

Any opinions?

@jogu
Copy link
Collaborator

jogu commented Sep 27, 2024

Resolved by #233 - this is how it now looks - the indentation is fixed and the language around the jwks contents has been significantly reworked:

Screenshot 2024-09-27 at 09 42 25

@jogu jogu closed this as completed Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants