-
Notifications
You must be signed in to change notification settings - Fork 28
Clarified language around release notes #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into |
|
@JesperIRL This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Domest0s
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements. I like them.
| * Release notes across backports | ||
| * If an issue is backported to earlier releases the same note will be used - just add the new release version in the [Affects Version/s]{.jbs-field} field of the release note. | ||
| * Where a different release note is required, then create a separate note with the affects version for the new release - see [JDK-8308194](https://bugs.openjdk.org/browse/JDK-8308194) and [JDK-8322473](https://bugs.openjdk.org/browse/JDK-8322473) for an example. | ||
| * If an issue is backported to earlier releases the same release note will be used - just add the new release version in the [Affects Version/s]{.jbs-field} and [Fix Version/s]{.jbs-field} fields of the release note sub-task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a missing comma.
| * If an issue is backported to earlier releases the same release note will be used - just add the new release version in the [Affects Version/s]{.jbs-field} and [Fix Version/s]{.jbs-field} fields of the release note sub-task. | |
| * If an issue is backported to earlier releases, the same release note will be used - just add the new release version in the [Affects Version/s]{.jbs-field} and [Fix Version/s]{.jbs-field} fields of the release note sub-task. |
The word "note" was used to refer to a release note, a release note sub-task, and a comment in a JBS issue - this could be confusing. Made it more explicit.
Also updated the usage of Fix version for release notes which was not described correctly.
Progress
Reviewers
Reviewers without OpenJDK IDs
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/guide.git pull/164/head:pull/164$ git checkout pull/164Update a local copy of the PR:
$ git checkout pull/164$ git pull https://git.openjdk.org/guide.git pull/164/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 164View PR using the GUI difftool:
$ git pr show -t 164Using diff file
Download this PR as a diff file:
https://git.openjdk.org/guide/pull/164.diff
Using Webrev
Link to Webrev Comment