Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Oct 28, 2025

Fixes recent regression in JDK 24+.

Additional testing:

  • Linux x86_64 server fastdebug, compiler/codegen/aes/ fails without the product fix, passes with it
  • Linux x86_64 server fastdebug, all

Progress

  • JDK-8370318 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8370318: AES-GCM vector intrinsic may read out of bounds (x86_64, AVX-512) (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u.git pull/347/head:pull/347
$ git checkout pull/347

Update a local copy of the PR:
$ git checkout pull/347
$ git pull https://git.openjdk.org/jdk25u.git pull/347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 347

View PR using the GUI difftool:
$ git pr show -t 347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u/pull/347.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2025

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7bb490c4bf7ae55547e4468da0795dac0a873d2b 8370318: AES-GCM vector intrinsic may read out of bounds (x86_64, AVX-512) Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2025

Webrevs

@shipilev
Copy link
Member Author

/approval request Fixes recent regression in JDK 24+ that leads to JVM crash in limited conditions. Applies cleanly. All tests pass. Existing regression tests fail without the product fix, pass with it. The patch is relatively new, but the issue and the fix are well understood. The risk is medium: touches the core parts, but in a simple manner.

@openjdk
Copy link

openjdk bot commented Oct 29, 2025

@shipilev
8370318: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant