-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Pyccel: a Python-to-X transpiler for scientific high-performance computing #4991
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 @yguclu please fix the incorrectly formatted DOI that editorialbot found. After you make the change to your .bib file, then use the command |
👋 @aholmes, @IgorBaratta, and @boegel - Thanks for agreeing to review this submission. As you can see above, you each should use the command As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use editorialbot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
Review checklist for @boegelConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @aholmesConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
JOSS submission [requires](https://joss.readthedocs.io/en/latest/submitting.html#substantial-scholarly-effort) "... that software should be feature-complete (i.e., no half-baked solutions), packaged appropriately according to common community standards for the programming language being used." I identified that, upon installing the defined dependencies (in setup.cfg) with `pip install -e .`, `pytest` was not runnable. The dependencies for `pytest` are listed in [README.md](https://github.com/pyccel/pyccel/blob/8ca23f07fa9aed4ed1974c7b7d6f427bcce7f7df/README.md#requirements), however, this requires manual management of development dependencies to maintain. Therefore, this PR adds the test dependencies to setup.cfg as "optional," which allows them to be installed with `pip install -e .[test]` - thus leaving the "production" dependencies as they are. In addition, the "pytest-xdist," "astunparse," and "tblib" dependencies that are not explicitly mentioned under "Requirements" have been added to setup.cfg. Documentation on how to install these dependencies has been updated. Related: openjournals/joss-reviews#4991
@editorialbot check references |
|
@editorialbot generate pdf |
Review checklist for @IgorBarattaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
In pyccel#5, benchmarks were moved to the tests/ directory from the benchmark_code/ directory. This change updates that path. This error is received on attempting to run the benchmarks: ```sh $ python benchmarks/run_benchmarks.py --verbose =========================================== Ackermann =========================================== Traceback (most recent call last): File "/home/aholmes/repos/pyccel-benchmarks/benchmarks/run_benchmarks.py", line 209, in <module> shutil.copyfile(test_file, os.path.join(new_folder, basename)) File "/usr/lib/python3.10/shutil.py", line 254, in copyfile with open(src, 'rb') as fsrc: FileNotFoundError: [Errno 2] No such file or directory: '/home/aholmes/repos/pyccel-benchmarks/benchmarks/benchmark_code/ackermann_mod.py' ``` Related: http://openjournals/joss-reviews#4991
Indeed. The latest Pyccel version on PyPI is now 1.7.3, but the benchmarks in the article were run with version 1.7.2. Hence we stick to 1.7.2. |
|
The DOI of the archived version is : https://doi.org/10.5281/zenodo.7711108 |
@danielskatz Our checklist is now complete. Thank you for your help with the review process. And thanks to the reviewers for their time and helpful interactions. |
@editorialbot set v1.7.2 as version |
Done! version is now v1.7.2 |
@editorialbot set 10.5281/zenodo.7711108 as archive |
Done! Archive is now 10.5281/zenodo.7711108 |
@editorialbot recommend-accept this will generate the final proof that I will then check over and perhaps get back to you about |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4039, then you can now move forward with accepting the submission by compiling again with the command |
@yguclu and @EmilyBourne - I've suggested some minor changes in pyccel/pyccel#1341 - please merge this, or let me know what you disagree with, then we can proceed to publication. |
@editorialbot recommend-accept hopefully final check |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4040, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @yguclu (Yaman Güçlü), @EmilyBourne, and co-authors!! And thanks to @aholmes, @IgorBaratta, and @boegel for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you @danielskatz, @aholmes, @IgorBaratta and @boegel!! The review process has been well organized and insightful. I have really appreciated your input, which has allowed us to improve Pyccel! |
Submitting author: @yguclu (Yaman Güçlü)
Repository: https://github.com/pyccel/pyccel/
Branch with paper.md (empty if default branch): joss-paper
Version: v1.7.2
Editor: @danielskatz
Reviewers: @aholmes, @IgorBaratta, @boegel
Archive: 10.5281/zenodo.7711108
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@aholmes & @IgorBaratta & @boegel, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @aholmes
📝 Checklist for @boegel
📝 Checklist for @IgorBaratta
The text was updated successfully, but these errors were encountered: