Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create .github repo #1395

Open
ctcpip opened this issue Nov 12, 2024 · 6 comments
Open

create .github repo #1395

ctcpip opened this issue Nov 12, 2024 · 6 comments
Assignees

Comments

@ctcpip
Copy link
Member

ctcpip commented Nov 12, 2024

original issue is here: #1263 (comment)

the CPC agreed to create this repo and populate the appropriate files

@ctcpip ctcpip changed the title create .github repo create .github repo Nov 12, 2024
@ljharb
Copy link
Member

ljharb commented Nov 12, 2024

imo, go for it.

the CoC source of truth can either be in the CoC repo or in .github, and the other one should have a markdown file that links to the source of truth.

@tobie
Copy link
Contributor

tobie commented Nov 12, 2024

As long as the source-of-truth CoC stays in the CPC repo, I'm good.

@ljharb
Copy link
Member

ljharb commented Nov 12, 2024

That's fine, but can you elaborate on why that matters? If the source of truth was the .github repo, the CPC repo's file would contain a link to the new location.

The reason it matters is that if the source of truth is in the .github repo, github will automatically pick it up and display the link on PRs and whatnot.

@ctcpip
Copy link
Member Author

ctcpip commented Nov 12, 2024

the source of truth would ideally be in the .github repo, but this matter is separate from this issue which is just about creating the repo itself

@bensternthal
Copy link
Contributor

@ctcpip I created this repo and gave write permissions to the cpc-voting-members team (which I invited you to). I do need to audit that list, but that is a different task. Let me know if you need anything additional.

@tobie
Copy link
Contributor

tobie commented Nov 13, 2024

That's fine, but can you elaborate on why that matters? If the source of truth was the .github repo, the CPC repo's file would contain a link to the new location.

Coordinating changes across repo adds friction, causes risk of things getting out of sync, and tends to delay the CPC getting things done, so the benefits have to commensurable, imho.

The reason it matters is that if the source of truth is in the .github repo, github will automatically pick it up and display the link on PRs and whatnot.

Yeah, I don't see a ton of value in this happening for repos on the openjs-foundation GH org, tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants