Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependencies in setup.py #1

Open
ndkv opened this issue Nov 16, 2017 · 1 comment
Open

missing dependencies in setup.py #1

ndkv opened this issue Nov 16, 2017 · 1 comment

Comments

@ndkv
Copy link

ndkv commented Nov 16, 2017

The following dependencies are requires but missing from setup.py.

  • urllib3
  • chardet
  • certifi
  • idna

I'd add them in a pull request but don't know which versions are targeted.

@bartromgens
Copy link
Member

bartromgens commented Nov 20, 2017

@ndkv Those are all dependencies of the requests package and should be collected and installed when using pip install tkapi.

As far as I know I should not list these indirect dependencies in setup.py. Please let me know if this is not correct. And also how and where you got an error, if so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants