Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move more info nav link into tab navigation #74

Closed
wants to merge 1 commit into from

Conversation

chaserx
Copy link
Member

@chaserx chaserx commented Jan 17, 2016

fixes #62

screen shot 2016-01-17 at 4 25 47 pm

@chaserx
Copy link
Member Author

chaserx commented Jan 17, 2016

I've noticed a defect here where when you click into the about tab and try to get back to the facet tab that the tab is selected but the facet tab doesn't render.

@eeeschwartz
Copy link
Member

@chaserx the tab navigation is finicky because it's juggling the states of the facets, which are pretty brittle.

Unless it's high priority to make the "about" tab, I'd recommend leaving as part of the top navbar for now.

@chaserx chaserx closed this Jan 25, 2016
@ronnorthrip ronnorthrip deleted the move_about_into_its_own_tab branch May 4, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perhaps move more information as a fake tab
2 participants