Introduce readinessProbe

Author: akoptelov

Diff for: mina-common/Chart.yaml

@@ -2,5 +2,5 @@ apiVersion: v2
 name: mina-test-common
 description: Common templates for Mina test nodes
 type: library
-version: 0.0.2
+version: 0.0.3
 appVersion: "0.0.0"

Diff for: mina-common/templates/_values.yaml

@@ -0,0 +1,6 @@
+{{/*
+Get readiness probe value
+*/}}
+{{- define "mina-common.readinessProbe" }}
+{{- default (dig "global" "readinessProbe" "" .Values.AsMap) (dig "readinessProbe" "" .Values.AsMap) }}
+{{- end }}

Diff for: ocaml-test-node/Chart.lock

@@ -1,6 +1,6 @@
 dependencies:
 - name: mina-test-common
   repository: file://../mina-common
-  version: 0.0.2
-digest: sha256:06b9035c0407b0125c921251a176d591944cd8abcabab5ff525c4e411303eda2
-generated: "2023-11-16T12:51:57.76816585+03:00"
+  version: 0.0.3
+digest: sha256:097f88c43d1b8c3cbd192a064a8c6f44bcc87a694db6c6e601dc67e4d632c1b7
+generated: "2023-11-16T16:34:19.693845386+03:00"

Diff for: ocaml-test-node/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v2
 name: ocaml-test-node
 description: A Helm chart for OCaml Mina test node.
 type: application
-version: 0.0.2
+version: 0.0.3
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
@@ -13,4 +13,4 @@ appVersion: "2.0.0rampup4"
 dependencies:
   - name: mina-test-common
     repository: file://../mina-common
-    version: ">=0.0.2"
+    version: ">=0.0.3"

Diff for: ocaml-test-node/templates/_probes.tpl

@@ -0,0 +1,14 @@
+{{/*
+OCaml node readiness probe
+*/}}
+{{- define "ocaml-test-node.readinessProbe" }}
+{{- with include "mina-common.readinessProbe" . }}
+readinessProbe:
+  {{- if (eq . "P2PSocket") }}
+  tcpSocket:
+    port: "external"
+  {{- else }}
+  {{- fail (printf "unknown readiness probe kind: '%s'" .) }}
+  {{- end }}
+{{- end }}
+{{- end }}

Diff for: ocaml-test-node/templates/deployment.yaml

@@ -43,6 +43,7 @@ spec:
             {{- toYaml .Values.resources | nindent 12 }}
           volumeMounts:
             {{- include "ocaml-test-node.volumeMounts" . | indent 12 }}
+          {{ include "ocaml-test-node.readinessProbe" . | indent 10 }}
       volumes:
         {{- include "ocaml-test-node.volumes" . | indent 8 }}
       {{- with .Values.nodeSelector }}

Diff for: rust-test-node/Chart.lock

@@ -1,6 +1,6 @@
 dependencies:
 - name: mina-test-common
   repository: file://../mina-common
-  version: 0.0.1
-digest: sha256:14df3f6d0527897f35d4f1a99829ef21063b02ef8e095bd356b46af4bdb51a3f
-generated: "2023-11-13T12:55:04.060122744+03:00"
+  version: 0.0.2
+digest: sha256:56aba8d4369cc09440c0050dc60f6fca777f9f36bd15768f48ee3e31ed06ed71
+generated: "2023-11-16T14:59:29.620406417+03:00"

Diff for: rust-test-node/Chart.yaml

@@ -2,9 +2,9 @@ apiVersion: v2
 name: rust-test-node
 description: A Rust Mina test node
 type: application
-version: 0.0.1
+version: 0.0.2
 appVersion: "0.0.1"
 dependencies:
   - name: mina-test-common
     repository: file://../mina-common
-    version: ">0.0.0"
+    version: ">0.0.3"

Diff for: rust-test-node/templates/_probes.tpl

@@ -17,13 +17,20 @@ livenessProbe:
 Readiness probe: openmina node considered ready when it is in sync with the network.
 */}}
 {{- define "rust-test-node.readinessProbe" }}
-{{- if .Values.probes.readiness }}
+{{- with include "mina-common.readinessProbe" . }}
 readinessProbe:
+  {{- if eq . "Default" }}
   initialDelaySeconds: 60
   periodSeconds: 20
   failureThreshold: 60
   httpGet:
     path: /readyz
     port: 3000
+  {{- else if eq . "P2PSocket"}}
+  tcpSocket:
+    port: "external"
+  {{- else }}
+  {{- fail (printf "unknown readiness probe kind: '%s'" .) }}
+  {{- end }}
 {{- end }}
 {{- end }}

Diff for: rust-test-node/templates/deployment.yaml

@@ -49,6 +49,9 @@ spec:
             {{ include "rust-test-node.volumeMounts" . | indent 12 }}
           resources:
             {{- toYaml .Values.resources | nindent 12 }}
+          ports:
+            - name: external
+              containerPort: 8302
       volumes:
         {{ include "rust-test-node.volumes" . | indent 10 }}
       {{- with .Values.nodeSelector }}

Diff for: rust-test-node/values.yaml

@@ -4,7 +4,6 @@
 
 probes:
   liveness: true
-  readiness: true
 replicaCount: 1
 
 image: