Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

openmrs-spa.org/importmap.json does not have Cache-Control header #5

Open
joeldenning opened this issue Jun 6, 2019 · 1 comment
Open

Comments

@joeldenning
Copy link
Collaborator

It is important that https://openmrs-spa.org/import-map.json has a Cache-Control: public, must-revalidate, max-age=0 header so that when we deploy new code, everyone's browser checks the updated import map to download the new modules.

Right now, that header is not present as shown in the below screenshot:

image

@joeldenning
Copy link
Collaborator Author

Okay it looks like I'm wrong on this -- the server is sending the cache control header. But the browser is willfully disobeying the server's header because it doesn't like to not cache things. I think that the best solution would be to set the max-age to 10 seconds instead of 0, so that the browser actually honors the cache-control header.

See single-spa/import-map-deployer#11

joeldenning added a commit that referenced this issue Jun 20, 2019
Including zonejs for Angular
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant