Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crash when host lookup fails while trying to join a server #148

Open
mysy00 opened this issue Apr 17, 2024 · 1 comment
Open

Game crash when host lookup fails while trying to join a server #148

mysy00 opened this issue Apr 17, 2024 · 1 comment

Comments

@mysy00
Copy link
Contributor

mysy00 commented Apr 17, 2024

Launcher's log:

[00:00:00.002] (1054) INFO   starting 4 workers
[00:00:00.002] (1054) INFO   Tokio runtime found; starting in existing Tokio runtime
[00:00:08.409] (3f7c) INFO   [injector.rs] Address  samp.mysy.pl is not IPv4, trying to perform host lookup.
[00:00:08.410] (3f7c) INFO   [injector.rs] Host lookup for  samp.mysy.pl failed: Nieznany host. (os error 11001)

"Nieznany host" stands for "Unknown host".

Crash log:

SA-MP 0.3.7
Exception At Address: 0x00619BD3
Base: 0x03CF0000

Registers:
EAX: 0x00000007	EBX: 0x00000000	ECX: 0x00000005	EDX: 0x00000000
ESI: 0x56207466	EDI: 0x0086D380	EBP: 0x00000008	ESP: 0x0177F894
EFLAGS: 0x00210246

Stack:
+0000: 0x00000007   0x00400000   0x0074879F   0x00000025
+0010: 0x56207466   0x0000000A   0x0194399C   0x0177F958
+0020: 0xFFFFFFFF   0x012E2508   0x00000008   0x03C60F18
+0030: 0x622E238F   0x623388E8   0x0177F8DC   0x0177FBE0
+0040: 0x622DF69B   0x623388E8   0x0196E0B4   0x62367070
+0050: 0xFFFFFFFF   0x555C3A43   0x73726573   0x7669645C
+0060: 0x445C736F   0x746B7365   0x475C706F   0x53204154
+0070: 0x41206E61   0x6572646E   0x00007361   0x000000B4
+0080: 0x019ABE38   0x019ABE40   0x7721ABEE   0x00000000
+0090: 0x0082AC0E   0x000002D0   0x00000020   0x001B0014
+00A0: 0x0177F9D0   0x0196D804   0x622DFB94   0x00400000
+00B0: 0x00000000   0x0194399C   0x0000000A   0x0196E0B4
+00C0: 0x0177FA34   0x0177F988   0x622DDE46   0x0177F9B8
+00D0: 0x0177F9BC   0x0177F9C0   0x0177F9C4   0x0177F990
+00E0: 0x0177FA34   0x0196E0B4   0x0177F9D0   0x62333B58
+00F0: 0x00000000   0x0177F9DC   0x622DB83B   0x62338AB8
+0100: 0x01987828   0x00000002   0x00000000   0x00000008
+0110: 0x00000040   0x000307D0   0x00000064   0x00000038
+0120: 0x0177F990   0x00400000   0x00000000   0x0194399C
+0130: 0x0000000A   0x01987828   0x0196E0A0   0x0177FA20
+0140: 0x623336B8   0xFFFFFFFF   0x0177F9FC   0x622DFBBB
+0150: 0x0196E0B4   0x0177FA34   0x0177FBD8   0x0177FBDC
+0160: 0x0177FBE0   0x0177F990   0x0177FA2C   0x622DE202
+0170: 0x0177FA34   0x0177FBD8   0x0177FBDC   0x0177FBE0
+0180: 0x0177FBE4   0x01987828   0x0196E0A0   0x0177FBAC
+0190: 0x62333B58   0x00000000   0x0177FBB8   0x622E07BB
+01A0: 0x623389C0   0x01987828   0x0196E0B4   0x0177FBDC
+01B0: 0xFFFFFFFF   0x62333869   0x00000001   0x00000000
+01C0: 0x0177FBAC   0x00000000   0x0177FBD8   0x0177FBDC
+01D0: 0x0177FBE0   0x0177FBE4   0x0196E0B4   0x0177FBDC
+01E0: 0xFFFFFFFF   0x415C736F   0x61447070   0x4C5C6174
+01F0: 0x6C61636F   0x0196DE00   0x0196DCE0   0x0177FAB4
+0200: 0x0177FAB8   0x019AC530   0x0177FAB8   0x0177FB14
+0210: 0x62332DC8   0x00000000   0x0177FB20   0x622E216A
+0220: 0x019A0718   0x62338A28   0x62367070   0x0177FAD4
+0230: 0x623213C7   0x01940000   0x00000000   0x0196DDA0
+0240: 0x0177FB20   0x622E210E   0x00000000   0x00000000
+0250: 0x019A0718   0x0177FBC0   0x62338A28   0x62367070
+0260: 0x6232223D   0x0177FB1C   0x77775E0E   0xFFFFFFFF
+0270: 0x77775E0E   0x00000000   0x00000000   0x00000000

SCM Op: 0x0, lDbg: 0 LastRendObj: 0

Game Version: US 1.0

I believe it'd be best to show an error message instead of continuing and failing.

@AmyrAhmady
Copy link
Member

when host resolver fails, it means it fails to get raw IPv4 of your server to pass to samp, therefore launching it can cause a crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants