Add package manager agnostic build and dev scripts for Tauri #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please expand on why we should have "agnostic build scripts"? This project uses a Yarn lock file, hence every developer should install the dependencies using yarn as well. If you use npm or other dependency manager instead there's no guarantee you'll have the right dependency version installed, having multiple lock files is also not recommended and I'd also challenge why we should use different lock files as well. IMO this PR creates unnecessary complexity. I also don't quite understand why we're using Yarn at all but I guess that's a different topic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at having package manager agnostic build and development scripts for Tauri.
Previously, if you didn't have
yarninstalled, bothbuildanddevscript could not be executed as the Tauri scripts were not taking into account the user's development environment.This PR adds supports for both
npmandyarn, but may easily be extended to support other package managers.Closes #23