Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Reset reasoner #18

Closed
bowen-xu opened this issue Sep 15, 2023 · 5 comments · Fixed by #56
Closed

[Feature] Reset reasoner #18

bowen-xu opened this issue Sep 15, 2023 · 5 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request

Comments

@bowen-xu
Copy link
Collaborator

bowen-xu commented Sep 15, 2023

Is your feature request related to a problem? Please describe.

The function reset() of Reasoner has not been implemented yet.
https://github.com/bowen-xu/PyNARS/blob/b1142425a2af70dc76a185a70c7f6619c5376aaf/pynars/NARS/Control/Reasoner.py#L42-L44

This function is usefult when user want to restore the system to its initial state in a GUI without reopening it.

Describe the solution you'd like

Write a function to reset the system, including its memory, buffers, channels and so on.

@bowen-xu bowen-xu added the enhancement New feature or request label Sep 15, 2023
@bowen-xu bowen-xu self-assigned this Sep 15, 2023
@ccrock4t ccrock4t self-assigned this Sep 22, 2023
@ccrock4t
Copy link
Collaborator

This code will probably be closely linked to the code for #19

@bowen-xu
Copy link
Collaborator Author

This code will probably be closely linked to the code for #19

Yep. They're highly related. I think this issue is prior to #19

@ARCJ137442
Copy link
Contributor

ARCJ137442 commented Sep 27, 2023

I think this issue is prior to #19

Is it can be represented by "Load empty memory and experience"?

I think @ccrock4t 's saying is logically reasonable.

@bowen-xu
Copy link
Collaborator Author

I was trying to split the problem into smaller ones. To load experience, one can choose whether to reset the system or just to accumulate the experience upon old one. When loading a "memory" file, maybe the system should be reset, but if not I don't know whether it could work.

@ARCJ137442
Copy link
Contributor

To load experience, one can choose whether to reset the system or just to accumulate the experience upon old one. When loading a "memory" file, maybe the system should be reset, but if not I don't know whether it could work.

Oh yes, maybe I'm assuming that the "load" contains "reset" - in this aspect, you're right.
Accumulating memory is a good and novel idea for me. I think the key is combining concepts in memory.

Maybe pull request #27 can have a try, or at least it allow you run and manage multiple reasoners without run several Python program.

@ccrock4t ccrock4t removed their assignment Oct 25, 2023
@bowen-xu bowen-xu linked a pull request Nov 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants