Change output directory path for Datatables #342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Change output directory for datatables from
<repository top directory>/build/rewrite/datatables
to<gradle project directory>/build/reports/rewrite/datatables
What's your motivation?
Currently, when
setExportDatatables()
is set totrue
, the CSV files are exported to<repository top directory>/build/datatables
. However, I believe it would be better to change the output to thebuild
directory of each Gradle projects for the following two reasons.clean
task is executed.build
directory of each project.Files related to reports output during the execution of Gradle tasks are conventionally output to
<gradle project directory>/build/reports
. Also, considering that the patch file generated when executing therewriteDryRun
task is output tobuild/reports/rewrite/rewrite.patch
, I propose changing the output directory to<gradle project directory>/build/reports/rewrite/datatables
.exportDatatables
Function in Gradle Plugin #341Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist