`FinalClass` and `HideUtilityClassConstructor` should not apply for Spring Configuration classes

[kthoms]

The recipes org.openrewrite.staticanalysis.FinalClass and org.openrewrite.staticanalysis.HideUtilityClassConstructor must not be applied on classes that are annotated with org.springframework.context.annotation.Configuration.

What version of OpenRewrite are you using?

I am using

• Maven/Gradle plugin v6.17.0
• rewrite-static-analysis v2.16.0

How are you running OpenRewrite?

I am using the Maven plugin. The project can be checked out from https://github.com/operaton/operaton.git.

Remove the exclusions for FinalClass from /pom.xml and run

./mvnw -U org.openrewrite.maven:rewrite-maven-plugin:run

What is the smallest, simplest way to reproduce the problem?

@org.springframework.context.annotation.Configuration
class A {
}

What did you expect to see?

No change.

What did you see instead?

@org.springframework.context.annotation.Configuration
final class A {
}

or for HideUtilityClassConstructor

@org.springframework.context.annotation.Configuration
class A {
  private A () {}
}

Are you interested in contributing a fix to OpenRewrite?

Sorry, too busy for that ATM. We have excluded the few cases as workaround for the moment and are fine with that.

[timtebeek]

Thanks for the report! For HideUtilityClassConstructor there is already the option to provide a style with annotation classes that should not see their default constructor hidden:
https://github.com/openrewrite/rewrite/blob/03c458404073082275a752063887c188d213afbe/rewrite-java/src/main/java/org/openrewrite/java/style/HideUtilityClassConstructorStyle.java#L27-L33

rewrite-static-analysis/src/main/java/org/openrewrite/staticanalysis/HideUtilityClassConstructor.java

Lines 59 to 63 in 8e44876

	HideUtilityClassConstructorStyle style = cu.getStyle(HideUtilityClassConstructorStyle.class);
	if (style == null) {
	style = Checkstyle.hideUtilityClassConstructorStyle();
	}
	return new HideUtilityClassConstructorVisitor<>(style).visit(cu, ctx);

For FinalClass we don't yet have something similar; we could start out with not having that make any changes if any annotations are found, as to not make this Spring specific in rewrite-static-analysis.

[e5LA]

• Added excludeAnnotations in FinalClass in Enhance FinalClass with new exclusion options and includeNeverExtended option #735