Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Version increments breaks downstream plugins #5091

Open
peternied opened this issue Nov 4, 2022 · 0 comments
Open

[Bug] Version increments breaks downstream plugins #5091

peternied opened this issue Nov 4, 2022 · 0 comments
Labels
backwards-compatibility bug Something isn't working Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Priority-Medium

Comments

@peternied
Copy link
Member

peternied commented Nov 4, 2022

Problem

OpenSearch main its minor version from 2.4.0 -> 2.5.0, downstream repositories like security had its BWC tests broken because there was no 2.5.0 build available to consume by plugins.

This doesn't feel right. @peternied says that security repo is running 2.4.0 -> 3.0.0 BWC tests, when 3.0.0 was updated to 2.5.0 security repro broke with: java.lang.IllegalStateException: Received message from unsupported version: [2.4.0] minimal compatible version is: [2.5.0]. I think this is expected, the idea is that only latest 2.x will be upgradable to 3.0 when that ships, and this is what we're seeing now since 2.5 is a new thing that will exist.

@nknize Is this something we still want? Should we relax it?

It sounds like a sequencing problem and we just need a 2.5 distribution build, which is coming via automation in the 24 hours since 2.x was incremented to 2.5.

Originally posted by @dblock in #5090 (comment)

Expected behavior

  • In OpenSearch minor version changes do not introduce breaking changes, maybe we don't nee the wire sensitivity to break unless its a major version number?

OR

  • When OpenSearch updates its minor version and bwc suite there is a test process to ensure plugins can build and execute the tests correctly
@peternied peternied changed the title Version increments don't have a check to prevent downstream failurse [Bug] Version increments don't have a check to prevent downstream failurse Nov 4, 2022
@peternied peternied changed the title [Bug] Version increments don't have a check to prevent downstream failurse [Bug] Version increments breaks downstream plugins Nov 4, 2022
@minalsha minalsha removed the untriaged label Nov 8, 2022
@peterzhuamazon peterzhuamazon added the Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility bug Something isn't working Build Libraries & Interfaces Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Priority-Medium
Projects
None yet
Development

No branches or pull requests

4 participants