Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] Streaming Indexing API #9065

Open
7 of 10 tasks
reta opened this issue Aug 2, 2023 · 8 comments
Open
7 of 10 tasks

[META] Streaming Indexing API #9065

reta opened this issue Aug 2, 2023 · 8 comments
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Meta Meta issue, not directly linked to a PR Roadmap:Cost/Performance/Scale Project-wide roadmap label

Comments

@reta
Copy link
Collaborator

reta commented Aug 2, 2023

@reta reta added enhancement Enhancement or improvement to existing feature or request Meta Meta issue, not directly linked to a PR Indexing & Search labels Aug 2, 2023
@reta reta self-assigned this Aug 2, 2023
@reta reta removed the untriaged label Aug 2, 2023
@dblock
Copy link
Member

dblock commented Aug 3, 2023

@reta pretty great stuff - there's other work on improving client/server performance, how do you see us fit work on Protobuf (@VachaShah) / gRPC?

@reta
Copy link
Collaborator Author

reta commented Aug 3, 2023

@reta pretty great stuff - there's other work on improving client/server performance, how do you see us fit work on Protobuf (@VachaShah) / gRPC?

Thanks @dblock, the gRPC would definitely benefit from the reactive streaming part. From other side, I assume the gRPC would be used as node transport layer (at least, initially), so the HTTP reactive layer (as suggested alternative transport for HTTP clients) would benefit enormously from that - we will be having end-to-end reactive processing pipeline.

@anasalkouz anasalkouz added Indexing Indexing, Bulk Indexing and anything related to indexing and removed Indexing & Search labels Sep 19, 2023
@shwetathareja
Copy link
Member

@reta Looking to collaborate on the Streaming API changes and see by when it can make it to OpenSearch release.

@reta
Copy link
Collaborator Author

reta commented Oct 16, 2023

@reta Looking to collaborate on the Streaming API changes and see by when it can make it to OpenSearch release.

@shwetathareja that would be great, the first thing is to get this one in #9672 - the pull request adds new HTTP transport based on Reactor Netty 4 with streaming support, it is well on schedule for 2.12. What is left there is testing part, since this transport is not default (and experimental), needs some ad-hoc testing. I should be able to wrap it up this week (the two back to back releases derailed the plans a bit).

Once the transport is there, we could split the work, there are quite a few opportunities for doing that in parallel, thank you.

@shwetathareja
Copy link
Member

@reta sounds good. I will also go through #9672 to get better understanding. Lets connect next week around how we can split the remaining work. Looking forward to working together. Thank you!

@T-J-L
Copy link

T-J-L commented Sep 19, 2024

Hi, I'm really interested in testing this feature.

Does the current implementation support bi-directional streaming, I.e. returning responses for each chunk/document?

Currently I'm streaming the request, but OpenSearch appears to wait until the request is complete before sending the response. Not sure whether my setup is wrong, or if this is expected.

Thanks

Edit: this works as expected. My code was the issue!

@reta
Copy link
Collaborator Author

reta commented Sep 19, 2024

Does the current implementation support bi-directional streaming, I.e. returning responses for each chunk/document?

Just for visibility, yes the implementation support bi-directional streaming, thanks @T-J-L !

@thomas-long-f3
Copy link

I didn't want to clutter this issue so created a separate one here, but any help would be appreciated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing Meta Meta issue, not directly linked to a PR Roadmap:Cost/Performance/Scale Project-wide roadmap label
Projects
Status: New
Development

No branches or pull requests

7 participants