From b47f182343108ea6d71ca9c4dbd714158f3f694b Mon Sep 17 00:00:00 2001 From: Marc Handalian Date: Mon, 14 Aug 2023 14:15:29 -0700 Subject: [PATCH] Change noisy logs on SegRep and remote store paths to trace level Signed-off-by: Marc Handalian --- .../org/opensearch/index/shard/IndexShard.java | 14 +++++++------- .../index/shard/RemoteStoreRefreshListener.java | 2 +- .../index/store/RemoteSegmentStoreDirectory.java | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/server/src/main/java/org/opensearch/index/shard/IndexShard.java b/server/src/main/java/org/opensearch/index/shard/IndexShard.java index 440f175aaf46d..d3b3f14726682 100644 --- a/server/src/main/java/org/opensearch/index/shard/IndexShard.java +++ b/server/src/main/java/org/opensearch/index/shard/IndexShard.java @@ -1641,20 +1641,20 @@ public Tuple, ReplicationCheckpoint> getLatestSegme */ public boolean isSegmentReplicationAllowed() { if (indexSettings.isSegRepEnabled() == false) { - logger.warn("Attempting to perform segment replication when it is not enabled on the index"); + logger.trace("Attempting to perform segment replication when it is not enabled on the index"); return false; } if (getReplicationTracker().isPrimaryMode()) { - logger.warn("Shard is in primary mode and cannot perform segment replication as a replica."); + logger.trace("Shard is in primary mode and cannot perform segment replication as a replica."); return false; } if (this.routingEntry().primary()) { - logger.warn("Shard routing is marked primary thus cannot perform segment replication as replica"); + logger.trace("Shard routing is marked primary thus cannot perform segment replication as replica"); return false; } if (state().equals(IndexShardState.STARTED) == false && (state() == IndexShardState.POST_RECOVERY && shardRouting.state() == ShardRoutingState.INITIALIZING) == false) { - logger.warn( + logger.trace( () -> new ParameterizedMessage( "Shard is not started or recovering {} {} and cannot perform segment replication as a replica", state(), @@ -1664,7 +1664,7 @@ public boolean isSegmentReplicationAllowed() { return false; } if (getReplicationEngine().isEmpty()) { - logger.warn( + logger.trace( () -> new ParameterizedMessage( "Shard does not have the correct engine type to perform segment replication {}.", getEngine().getClass() @@ -4815,8 +4815,8 @@ private String copySegmentFiles( } } } finally { - logger.info("Downloaded segments here: {}", downloadedSegments); - logger.info("Skipped download for segments here: {}", skippedSegments); + logger.trace("Downloaded segments here: {}", downloadedSegments); + logger.trace("Skipped download for segments here: {}", skippedSegments); } return segmentNFile; } diff --git a/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java b/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java index 9fbc3748f9383..3e8990430417b 100644 --- a/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java +++ b/server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java @@ -189,7 +189,7 @@ private boolean shouldSync(boolean didRefresh) { private boolean syncSegments() { if (indexShard.getReplicationTracker().isPrimaryMode() == false || indexShard.state() == IndexShardState.CLOSED) { - logger.info( + logger.trace( "Skipped syncing segments with primaryMode={} indexShardState={}", indexShard.getReplicationTracker().isPrimaryMode(), indexShard.state() diff --git a/server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java b/server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java index 9d5adc241ea0e..fbb67c23aa848 100644 --- a/server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java +++ b/server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java @@ -200,7 +200,7 @@ public RemoteSegmentMetadata readLatestMetadataFile() throws IOException { logger.trace("Reading latest Metadata file {}", latestMetadataFile); remoteSegmentMetadata = readMetadataFile(latestMetadataFile); } else { - logger.info("No metadata file found, this can happen for new index with no data uploaded to remote segment store"); + logger.trace("No metadata file found, this can happen for new index with no data uploaded to remote segment store"); } return remoteSegmentMetadata; @@ -786,7 +786,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException Integer.MAX_VALUE ); if (sortedMetadataFileList.size() <= lastNMetadataFilesToKeep) { - logger.info( + logger.trace( "Number of commits in remote segment store={}, lastNMetadataFilesToKeep={}", sortedMetadataFileList.size(), lastNMetadataFilesToKeep @@ -849,7 +849,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException } }); if (deletionSuccessful.get()) { - logger.info("Deleting stale metadata file {} from remote segment store", metadataFile); + logger.trace("Deleting stale metadata file {} from remote segment store", metadataFile); remoteMetadataDirectory.deleteFile(metadataFile); } }