Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix lucene HNSW vector dimensionality. #7886

Closed
2 tasks done
Devanshu24 opened this issue Aug 1, 2024 · 2 comments · Fixed by #8051
Closed
2 tasks done

[DOC] Fix lucene HNSW vector dimensionality. #7886

Devanshu24 opened this issue Aug 1, 2024 · 2 comments · Fixed by #8051
Assignees
Labels
1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR.

Comments

@Devanshu24
Copy link

Devanshu24 commented Aug 1, 2024

What do you want to do?

  • Request a change to existing documentation
  • Report a technical problem with the documentation

Tell us about your request. Provide a summary of the request.
From the docs,

| | NMSLIB/HNSW | Faiss/HNSW | Faiss/IVF | Lucene/HNSW |
|:---|:---|:---|:---|:---|
| Max dimensions | 16,000 | 16,000 | 16,000 | 1,024 |
it states the max dimension for vectors in 1,024. However, that seems outdated after this addition (opensearch-project/k-NN#1346), which is also released(https://github.com/opensearch-project/k-NN/releases/tag/2.12.0.0) in 2.12.

*Version: List the OpenSearch version to which this issue applies, e.g. 2.14, 2.12--2.14, or all.
2.12+
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
There was also an effort to update the documentation but I believe this page was missed

@hdhalter
Copy link
Contributor

hdhalter commented Aug 2, 2024

Thanks for reporting this, @Devanshu24! Do you want to create the PR for this fix?

Tagging @kolchfa-aws, since that page on vector search is a recent update, and @junqiu-lei, since you implemented the fix. Thanks!

@hdhalter hdhalter added 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. and removed untriaged labels Aug 2, 2024
@Naarcha-AWS Naarcha-AWS self-assigned this Aug 19, 2024
@Naarcha-AWS Naarcha-AWS added 1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR. and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Aug 19, 2024
Naarcha-AWS added a commit that referenced this issue Aug 19, 2024
Fixes #7886 

Signed-off-by: Naarcha-AWS <[email protected]>
@Naarcha-AWS
Copy link
Collaborator

Thanks for bring this to our attention @Devanshu24! I submitted PR #8051 which should resolve the issue.

opensearch-trigger-bot bot pushed a commit that referenced this issue Aug 22, 2024
Fixes #7886

Signed-off-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 97fe260)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Backlog - DOC Doc writer assigned to issue responsible for creating PR.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants