Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][opensearch-dashboards] Add opensearchURL to values.yaml and document it #575

Open
schroedermatthias opened this issue Aug 18, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@schroedermatthias
Copy link

schroedermatthias commented Aug 18, 2024

Describe the bug
In the deployment.yaml the value .Values.opensearchURL is referenced:

It is not provided in the values.yaml. It also should be made clear, what's the purpose and difference of opensearchURL and opensearchHosts.
Additionaly, a hint would be nice, that opensearchHosts sets an environment variable which overrules the directive
opensearch.hosts: ... in /usr/share/opensearch-dashboards/config/opensearch_dashboards.yaml.

To Reproduce
Steps to reproduce the behavior:

  1. Install helm chart in version 2.20.0

Expected behavior
opensearchURL and opensearchHosts should be added to the values.yaml and documented.

Chart Name
opensearch-dashboards

@schroedermatthias schroedermatthias added bug Something isn't working untriaged Issues that have not yet been triaged labels Aug 18, 2024
@schroedermatthias schroedermatthias changed the title [BUG][opensearch-dashboards] [BUG][opensearch-dashboards] Add opensearchURL and opensearchHosts to values.yaml and document them Aug 18, 2024
@schroedermatthias schroedermatthias changed the title [BUG][opensearch-dashboards] Add opensearchURL and opensearchHosts to values.yaml and document them [BUG][opensearch-dashboards] Add opensearchURL to values.yaml and document it Aug 18, 2024
@prudhvigodithi
Copy link
Collaborator

[Triage]
Hey @schroedermatthias we should find the background of OPENSEARCH_URL and if not used anymore we should remove from the chart, coming from an example here https://github.com/opensearch-project/opensearch-build/blob/main/docker/release/dockercomposefiles/docker-compose-2.x.yml#L59C7-L59C23 I see the OPENSEARCH_HOSTS is one that is used.

@prudhvigodithi prudhvigodithi added good first issue Good for newcomers and removed untriaged Issues that have not yet been triaged labels Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

2 participants