fix: tests

Signed-off-by: Pavan Yekbote <[email protected]>

Author: pyek-bot

plugin/src/test/java/org/opensearch/ml/cluster/MLCommonsClusterEventListenerTests.java

@@ -10,6 +10,7 @@
 import static org.mockito.Mockito.never;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
+import static org.opensearch.ml.common.CommonValue.ML_JOBS_INDEX;
 import static org.opensearch.ml.common.CommonValue.TASK_POLLING_JOB_INDEX;
 
 import java.util.Collections;
@@ -82,45 +83,42 @@ public void testClusterChanged_WithV31DataNode_MetricCollectionEnabled() {
         listener.clusterChanged(event);
 
         verify(mlTaskManager).indexStatsCollectorJob(true);
-        verify(mlTaskManager, never()).startTaskPollingJob();
     }
 
-    public void testClusterChanged_WithV31DataNode_TaskPollingIndexExists() {
-        DiscoveryNode dataNode = createDataNode(Version.V_3_1_0);
-        setupClusterState(dataNode, true);
+    public void testClusterChanged_WithPreV31DataNode_NoJobsStarted() {
+        DiscoveryNode dataNode = createDataNode(Version.V_3_0_0);
+        setupClusterState(dataNode, false);
 
-        when(mlFeatureEnabledSetting.isMetricCollectionEnabled()).thenReturn(false);
+        when(mlFeatureEnabledSetting.isMetricCollectionEnabled()).thenReturn(true);
+        when(mlFeatureEnabledSetting.isStaticMetricCollectionEnabled()).thenReturn(true);
 
         listener.clusterChanged(event);
 
         verify(mlTaskManager, never()).indexStatsCollectorJob(anyBoolean());
-        verify(mlTaskManager).startTaskPollingJob();
     }
 
-    public void testClusterChanged_WithPreV31DataNode_NoJobsStarted() {
-        DiscoveryNode dataNode = createDataNode(Version.V_3_0_0);
-        setupClusterState(dataNode, true);
+    public void testClusterChanged_WithPostV31DataNode_JobsStarted() {
+        DiscoveryNode dataNode = createDataNode(Version.V_3_2_0);
+        setupClusterState(dataNode, false);
 
         when(mlFeatureEnabledSetting.isMetricCollectionEnabled()).thenReturn(true);
         when(mlFeatureEnabledSetting.isStaticMetricCollectionEnabled()).thenReturn(true);
 
         listener.clusterChanged(event);
 
-        verify(mlTaskManager, never()).indexStatsCollectorJob(anyBoolean());
-        verify(mlTaskManager, never()).startTaskPollingJob();
+        verify(mlTaskManager).indexStatsCollectorJob(true);
     }
 
-    public void testClusterChanged_WithPostV31DataNode_JobsStarted() {
-        DiscoveryNode dataNode = createDataNode(Version.V_3_2_0);
+    public void testClusterChanged_IndexAlreadyPresent_JobNotStarted() {
+        DiscoveryNode dataNode = createDataNode(Version.V_3_1_0);
         setupClusterState(dataNode, true);
 
         when(mlFeatureEnabledSetting.isMetricCollectionEnabled()).thenReturn(true);
         when(mlFeatureEnabledSetting.isStaticMetricCollectionEnabled()).thenReturn(true);
 
         listener.clusterChanged(event);
 
-        verify(mlTaskManager).indexStatsCollectorJob(true);
-        verify(mlTaskManager).startTaskPollingJob();
+        verify(mlTaskManager, never()).indexStatsCollectorJob(anyBoolean());
     }
 
     private DiscoveryNode createDataNode(Version version) {
@@ -134,7 +132,7 @@ private DiscoveryNode createDataNode(Version version) {
         );
     }
 
-    private void setupClusterState(DiscoveryNode node, boolean hasTaskPollingIndex) {
+    private void setupClusterState(DiscoveryNode node, boolean hasMLJobsIndex) {
         DiscoveryNodes nodes = DiscoveryNodes.builder().add(node).build();
 
         when(event.state()).thenReturn(clusterState);
@@ -143,7 +141,7 @@ private void setupClusterState(DiscoveryNode node, boolean hasTaskPollingIndex)
         when(clusterState.nodes()).thenReturn(nodes);
         when(clusterState.getMetadata()).thenReturn(metadata);
         when(clusterService.state()).thenReturn(clusterState);
-        when(metadata.hasIndex(TASK_POLLING_JOB_INDEX)).thenReturn(hasTaskPollingIndex);
+        when(metadata.hasIndex(ML_JOBS_INDEX)).thenReturn(hasMLJobsIndex);
         when(metadata.settings()).thenReturn(org.opensearch.common.settings.Settings.EMPTY);
     }
 }